|
1 | | -use cargo_toml::OptionalFile; |
2 | | -use derive_deref::Deref; |
3 | | -use serde::{de, Deserialize, Deserializer}; |
4 | | - |
5 | | -#[derive(Debug, Deserialize)] |
6 | | -pub struct Manifest { |
7 | | - #[serde(alias = "project")] |
8 | | - pub package: Package, |
9 | | -} |
10 | | - |
11 | | -#[derive(Debug, Deserialize)] |
12 | | -#[serde(rename_all = "kebab-case")] |
13 | | -pub struct Package { |
14 | | - pub name: String, |
15 | | - pub version: String, |
16 | | - #[serde(default)] |
17 | | - pub readme: OptionalFile, |
18 | | - pub repository: Option<String>, |
19 | | - pub rust_version: Option<RustVersion>, |
20 | | -} |
21 | | - |
22 | | -#[derive(Debug, Deref)] |
23 | | -pub struct RustVersion(String); |
24 | | - |
25 | | -impl PartialEq<&str> for RustVersion { |
26 | | - fn eq(&self, other: &&str) -> bool { |
27 | | - self.0.eq(other) |
28 | | - } |
29 | | -} |
30 | | - |
31 | | -impl<'de> Deserialize<'de> for RustVersion { |
32 | | - fn deserialize<D: Deserializer<'de>>(d: D) -> Result<RustVersion, D::Error> { |
33 | | - let s = String::deserialize(d)?; |
34 | | - match semver::VersionReq::parse(&s) { |
35 | | - // Exclude semver operators like `^` and pre-release identifiers |
36 | | - Ok(_) if s.chars().all(|c| c.is_ascii_digit() || c == '.') => Ok(RustVersion(s)), |
37 | | - Ok(_) | Err(..) => { |
38 | | - let value = de::Unexpected::Str(&s); |
39 | | - let expected = "a valid rust_version"; |
40 | | - Err(de::Error::invalid_value(value, &expected)) |
41 | | - } |
42 | | - } |
| 1 | +use cargo_toml::{Dependency, DepsSet, Error, Inheritable, Manifest, Package}; |
| 2 | + |
| 3 | +pub fn validate_manifest(manifest: &Manifest) -> Result<(), Error> { |
| 4 | + let package = manifest.package.as_ref(); |
| 5 | + |
| 6 | + // Check that a `[package]` table exists in the manifest, since crates.io |
| 7 | + // does not accept workspace manifests. |
| 8 | + let package = package.ok_or(Error::Other("missing field `package`"))?; |
| 9 | + |
| 10 | + validate_package(package)?; |
| 11 | + |
| 12 | + // These checks ensure that dependency workspace inheritance has been |
| 13 | + // normalized by cargo before publishing. |
| 14 | + if manifest.dependencies.is_inherited() |
| 15 | + || manifest.dev_dependencies.is_inherited() |
| 16 | + || manifest.build_dependencies.is_inherited() |
| 17 | + { |
| 18 | + return Err(Error::InheritedUnknownValue); |
| 19 | + } |
| 20 | + |
| 21 | + Ok(()) |
| 22 | +} |
| 23 | + |
| 24 | +pub fn validate_package(package: &Package) -> Result<(), Error> { |
| 25 | + // These checks ensure that package field workspace inheritance has been |
| 26 | + // normalized by cargo before publishing. |
| 27 | + if package.edition.is_inherited() |
| 28 | + || package.rust_version.is_inherited() |
| 29 | + || package.version.is_inherited() |
| 30 | + || package.authors.is_inherited() |
| 31 | + || package.description.is_inherited() |
| 32 | + || package.homepage.is_inherited() |
| 33 | + || package.documentation.is_inherited() |
| 34 | + || package.readme.is_inherited() |
| 35 | + || package.keywords.is_inherited() |
| 36 | + || package.categories.is_inherited() |
| 37 | + || package.exclude.is_inherited() |
| 38 | + || package.include.is_inherited() |
| 39 | + || package.license.is_inherited() |
| 40 | + || package.license_file.is_inherited() |
| 41 | + || package.repository.is_inherited() |
| 42 | + || package.publish.is_inherited() |
| 43 | + { |
| 44 | + return Err(Error::InheritedUnknownValue); |
| 45 | + } |
| 46 | + |
| 47 | + // Check that the `rust-version` field has a valid value, if it exists. |
| 48 | + if let Some(rust_version) = package.rust_version() { |
| 49 | + validate_rust_version(rust_version)?; |
| 50 | + } |
| 51 | + |
| 52 | + Ok(()) |
| 53 | +} |
| 54 | + |
| 55 | +trait IsInherited { |
| 56 | + fn is_inherited(&self) -> bool; |
| 57 | +} |
| 58 | + |
| 59 | +impl<T> IsInherited for Inheritable<T> { |
| 60 | + fn is_inherited(&self) -> bool { |
| 61 | + !self.is_set() |
| 62 | + } |
| 63 | +} |
| 64 | + |
| 65 | +impl<T: IsInherited> IsInherited for Option<T> { |
| 66 | + fn is_inherited(&self) -> bool { |
| 67 | + self.as_ref().map(|it| it.is_inherited()).unwrap_or(false) |
| 68 | + } |
| 69 | +} |
| 70 | + |
| 71 | +impl IsInherited for Dependency { |
| 72 | + fn is_inherited(&self) -> bool { |
| 73 | + matches!(self, Dependency::Inherited(_)) |
| 74 | + } |
| 75 | +} |
| 76 | + |
| 77 | +impl IsInherited for DepsSet { |
| 78 | + fn is_inherited(&self) -> bool { |
| 79 | + self.iter().any(|(_key, dep)| dep.is_inherited()) |
| 80 | + } |
| 81 | +} |
| 82 | + |
| 83 | +pub fn validate_rust_version(value: &str) -> Result<(), Error> { |
| 84 | + match semver::VersionReq::parse(value) { |
| 85 | + // Exclude semver operators like `^` and pre-release identifiers |
| 86 | + Ok(_) if value.chars().all(|c| c.is_ascii_digit() || c == '.') => Ok(()), |
| 87 | + Ok(_) | Err(..) => Err(Error::Other("invalid `rust-version` value")), |
43 | 88 | } |
44 | 89 | } |
0 commit comments