This repository was archived by the owner on May 28, 2025. It is now read-only.
Commit 8818871
committed
Auto merge of rust-lang#129469 - jieyouxu:exp-msvc-ci, r=<try>
[Experimental] what if we use symlink_metadata
r? ghost
Follow up to information revealed in rust-lang#129431.
The cargo branch contains a change:
```diff
diff --git a/crates/cargo-util/src/paths.rs b/crates/cargo-util/src/paths.rs
index 59e812f..d2f023da3ce 100644
--- a/crates/cargo-util/src/paths.rs
+++ b/crates/cargo-util/src/paths.rs
`@@` -571,7 +571,9 `@@` where
}
fn set_not_readonly(p: &Path) -> io::Result<bool> {
- let mut perms = p.metadata()?.permissions();
+ // Note that `p` is possibly a symlink. What if this is
+ // `symlink_metadata`?
+ let mut perms = p.symlink_metadata()?.permissions();
if !perms.readonly() {
return Ok(false);
}
```
try-job: x86_64-msvc-ext1 file changed
+2
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
0 commit comments