Fix 9219: OpenAIAgent using AzureOpenAI not working with stream_chat and astream_chat #9890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
hatianzhang
reviewed
Jan 8, 2024
| else: | ||
| delta = ChoiceDelta() | ||
| if self._is_azure_client(): | ||
| continue |
There was a problem hiding this comment.
will it cause some missing data if delta is not returning properly
There was a problem hiding this comment.
It shouldn't -- azure is kind of mis-using the API by returning chunks with no content at the start (instead, it has some safety info or something silly)
logan-markewich
approved these changes
Jan 8, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
AzureOpenAI()with stream_chat or astream_chat, occasionally the Azure API will return empty responses initially. Adding a check and simply continuing until the next response seems to fix this issue. This issue is described in the following posts:#9219
run-llama/sec-insights#64
run-llama/sec-insights#78
Fixes #9219
Type of Change
How Has This Been Tested?
Used the test code provided by @fchenGT in #9219, and implemented fix in Azure version of https://github.com/run-llama/sec-insights
Suggested Checklist: