Skip to content

Commit 6ab10e3

Browse files
fix superlinked package (#19673)
1 parent cc34a62 commit 6ab10e3

File tree

10 files changed

+1495
-467
lines changed

10 files changed

+1495
-467
lines changed

llama-index-integrations/retrievers/llama-index-retrievers-superlinked/examples/steam_games_example.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"import pandas as pd\n",
2626
"\n",
2727
"import superlinked.framework as sl\n",
28-
"from llama_index_retrievers_superlinked import SuperlinkedRetriever\n",
28+
"from llama_index.retrievers.superlinked import SuperlinkedRetriever\n",
2929
"\n",
3030
"try:\n",
3131
" from llama_index.core.query_engine import RetrieverQueryEngine\n",

llama-index-integrations/retrievers/llama-index-retrievers-superlinked/examples/steam_games_example.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import pandas as pd
1919

2020
import superlinked.framework as sl
21-
from llama_index_retrievers_superlinked import SuperlinkedRetriever
21+
from llama_index.retrievers.superlinked import SuperlinkedRetriever
2222

2323
try:
2424
from llama_index.core.query_engine import RetrieverQueryEngine
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
"""
2+
Superlinked retriever integration for LlamaIndex.
3+
"""
4+
5+
from llama_index.retrievers.superlinked.retriever import SuperlinkedRetriever
6+
7+
__all__ = ["SuperlinkedRetriever"]
Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
1-
from __future__ import annotations
2-
31
from typing import Any, List, Optional
42

53
from llama_index.core.retrievers import BaseRetriever
64
from llama_index.core.schema import QueryBundle, NodeWithScore, TextNode
75
from llama_index.core.callbacks.base import CallbackManager
8-
from superlinked.framework.dsl.app.app import App # type: ignore # noqa: F401
9-
from superlinked.framework.dsl.query.query_descriptor import ( # type: ignore # noqa: F401
6+
from superlinked.framework.dsl.app.app import App
7+
from superlinked.framework.dsl.query.query_descriptor import (
108
QueryDescriptor,
119
)
1210

@@ -22,8 +20,8 @@ class SuperlinkedRetriever(BaseRetriever):
2220
def __init__(
2321
self,
2422
*,
25-
sl_client: Any,
26-
sl_query: Any,
23+
sl_client: App,
24+
sl_query: QueryDescriptor,
2725
page_content_field: str,
2826
query_text_param: str = "query_text",
2927
metadata_fields: Optional[List[str]] = None,
@@ -59,8 +57,7 @@ def __init__(
5957
# Initialize BaseRetriever
6058
super().__init__(callback_manager=callback_manager)
6159

62-
# LlamaIndex retrievers implement _retrieve(QueryBundle)
63-
def _retrieve(self, query_bundle: QueryBundle) -> List[NodeWithScore]: # type: ignore[override]
60+
def _retrieve(self, query_bundle: QueryBundle) -> List[NodeWithScore]:
6461
"""
6562
Execute the Superlinked query and map results to nodes.
6663
Lines changed: 12 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[build-system]
2-
requires = ["setuptools>=68", "wheel"]
3-
build-backend = "setuptools.build_meta"
2+
requires = ["hatchling"]
3+
build-backend = "hatchling.build"
44

55
[dependency-groups]
66
dev = [
@@ -10,10 +10,10 @@ dev = [
1010

1111
[project]
1212
name = "llama-index-retrievers-superlinked"
13-
version = "0.1.0"
13+
version = "0.1.1"
1414
description = "LlamaIndex retriever integration for Superlinked"
1515
readme = "README.md"
16-
requires-python = ">=3.9,<4.0"
16+
requires-python = ">=3.10,<4.0"
1717
license = {text = "MIT"}
1818
authors = [
1919
{name = "Superlinked", email = "[email protected]"},
@@ -32,6 +32,14 @@ dependencies = [
3232
[project.urls]
3333
Homepage = "https://github.com/run-llama/llama_index"
3434

35+
[tool.hatch.build.targets.sdist]
36+
include = ["llama_index/"]
37+
exclude = ["**/BUILD"]
38+
39+
[tool.hatch.build.targets.wheel]
40+
include = ["llama_index/"]
41+
exclude = ["**/BUILD"]
42+
3543
[tool.llamahub]
3644
contains_example = true
3745
import_path = "llama_index.retrievers.superlinked"
@@ -42,16 +50,3 @@ SuperlinkedRetriever = "Superlinked"
4250
[tool.pytest.ini_options]
4351
addopts = "-q"
4452
pythonpath = ["src"]
45-
46-
[tool.setuptools]
47-
package-dir = {"" = "src"}
48-
49-
[tool.setuptools.packages.find]
50-
where = ["src"]
51-
include = [
52-
"llama_index*",
53-
"llama_index_retrievers_superlinked*",
54-
]
55-
exclude = [
56-
"tests*",
57-
]

llama-index-integrations/retrievers/llama-index-retrievers-superlinked/src/llama_index/retrievers/superlinked/__init__.py

Lines changed: 0 additions & 14 deletions
This file was deleted.

llama-index-integrations/retrievers/llama-index-retrievers-superlinked/src/llama_index_retrievers_superlinked/__init__.py

Lines changed: 0 additions & 3 deletions
This file was deleted.

llama-index-integrations/retrievers/llama-index-retrievers-superlinked/tests/test_integration_superlinked_retriever.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
"""Integration-like tests using only mocks to simulate Superlinked behavior."""
22

3-
from __future__ import annotations
4-
3+
import pytest
54
from typing import Any, List
65
from unittest.mock import Mock
76

8-
import pytest
7+
from llama_index.retrievers.superlinked import SuperlinkedRetriever
98

109

1110
# Patch superlinked modules once for all tests
@@ -42,8 +41,6 @@ def _make_entries(docs: List[dict]) -> list:
4241

4342

4443
def test_basic_flow() -> None:
45-
from llama_index_retrievers_superlinked import SuperlinkedRetriever
46-
4744
retriever = SuperlinkedRetriever(
4845
sl_client=MockApp(),
4946
sl_query=MockQuery(),
@@ -69,8 +66,6 @@ def test_basic_flow() -> None:
6966

7067

7168
def test_k_limit_and_metadata_subset() -> None:
72-
from llama_index_retrievers_superlinked import SuperlinkedRetriever
73-
7469
retriever = SuperlinkedRetriever(
7570
sl_client=MockApp(),
7671
sl_query=MockQuery(),
@@ -98,8 +93,6 @@ def test_k_limit_and_metadata_subset() -> None:
9893

9994

10095
def test_error_returns_empty_list() -> None:
101-
from llama_index_retrievers_superlinked import SuperlinkedRetriever
102-
10396
retriever = SuperlinkedRetriever(
10497
sl_client=MockApp(),
10598
sl_query=MockQuery(),

llama-index-integrations/retrievers/llama-index-retrievers-superlinked/tests/test_unit_superlinked_retriever.py

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
"""Unit tests for SuperlinkedRetriever (LlamaIndex)."""
22

3-
from __future__ import annotations
4-
3+
import pytest
54
from typing import Any
65
from unittest.mock import Mock
76

8-
import pytest
7+
from llama_index.retrievers.superlinked import SuperlinkedRetriever
98

109

1110
# Patch superlinked types before importing the retriever to satisfy validators
@@ -32,8 +31,6 @@ def _patch_superlinked_modules(monkeypatch: Any) -> None:
3231

3332

3433
def test_retriever_validate_and_retrieve_success() -> None:
35-
from llama_index_retrievers_superlinked import SuperlinkedRetriever
36-
3734
retriever = SuperlinkedRetriever(
3835
sl_client=MockApp(),
3936
sl_query=MockQuery(),
@@ -69,8 +66,6 @@ def test_retriever_validate_and_retrieve_success() -> None:
6966

7067

7168
def test_retriever_respects_k() -> None:
72-
from llama_index_retrievers_superlinked import SuperlinkedRetriever
73-
7469
retriever = SuperlinkedRetriever(
7570
sl_client=MockApp(),
7671
sl_query=MockQuery(),
@@ -95,8 +90,6 @@ def test_retriever_respects_k() -> None:
9590

9691

9792
def test_retriever_metadata_fields_subset() -> None:
98-
from llama_index_retrievers_superlinked import SuperlinkedRetriever
99-
10093
retriever = SuperlinkedRetriever(
10194
sl_client=MockApp(),
10295
sl_query=MockQuery(),
@@ -116,8 +109,6 @@ def test_retriever_metadata_fields_subset() -> None:
116109

117110

118111
def test_retriever_missing_page_content_skips() -> None:
119-
from llama_index_retrievers_superlinked import SuperlinkedRetriever
120-
121112
retriever = SuperlinkedRetriever(
122113
sl_client=MockApp(),
123114
sl_query=MockQuery(),
@@ -136,8 +127,6 @@ def test_retriever_missing_page_content_skips() -> None:
136127

137128

138129
def test_retriever_query_exception_returns_empty() -> None:
139-
from llama_index_retrievers_superlinked import SuperlinkedRetriever
140-
141130
retriever = SuperlinkedRetriever(
142131
sl_client=MockApp(),
143132
sl_query=MockQuery(),
@@ -150,8 +139,6 @@ def test_retriever_query_exception_returns_empty() -> None:
150139

151140

152141
def test_query_text_param_is_used() -> None:
153-
from llama_index_retrievers_superlinked import SuperlinkedRetriever
154-
155142
retriever = SuperlinkedRetriever(
156143
sl_client=MockApp(),
157144
sl_query=MockQuery(),

0 commit comments

Comments
 (0)