Skip to content

Conversation

@duffn
Copy link
Member

@duffn duffn commented Mar 26, 2023

This adds a test matrix for multiple versions of Ruby and grape-swagger.

I've tried to leave as much the same as I could, but some changes were necessary and I've also made a few guesses here:

  • Support Ruby 2.7+
  • Support grape-swagger >= 1.6.0
    • The old matrix had very old versions of the package, the most recent being from June 2019. I can add some more recent versions to the matrix if requested and can see what happens, but am not sure how many different versions we want to support.
  • Support railties >= 6

Other notes

  • Added inflections initializer for Failure/Error: mount API => '/'
  • Sorted Gemfile
  • Updated mime-types for error on Ruby 3 SyntaxError: /home/runner/work/grape-swagger-rails/grape-swagger-rails/vendor/bundle/ruby/3.0.0/gems/mime-types-2.99.3/lib/mime/types/logger.rb:26: _1 is reserved for numbered parameter
  • Added webrick for Ruby 3
  • Update rack to solve resolution conflicts
  • gemspec rubocop formatting
  • Update GitHub Actions versions

TODO

@duffn duffn force-pushed the duffn/test-matrix branch from 54c27da to a3591b3 Compare March 27, 2023 00:09
@duffn duffn marked this pull request as ready for review March 27, 2023 00:17
@dblock
Copy link
Member

dblock commented Mar 27, 2023

@grape-bot
Copy link

grape-bot commented Mar 27, 2023

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 Danger

@duffn duffn changed the title Add test matrix for multiple Ruby versions Add test matrix for multiple Ruby versions & update dependencies Mar 27, 2023
@dblock dblock merged commit 65b0e00 into ruby-grape:master Mar 27, 2023
@dblock
Copy link
Member

dblock commented Mar 27, 2023

Shall we increment the version to 0.4.0 and make a release? Want to help @duffn, remind me your Rubygems username?

@duffn
Copy link
Member Author

duffn commented Mar 27, 2023

@dblock Yeah, sounds good. It’s the same username.

@duffn duffn deleted the duffn/test-matrix branch March 27, 2023 11:37
@dblock
Copy link
Member

dblock commented Mar 27, 2023

Added you!

@duffn
Copy link
Member Author

duffn commented Mar 27, 2023

Accepted, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants