Skip to content

fix timeout check to use timeout_interval #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2018
Merged

fix timeout check to use timeout_interval #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/concurrent/timer_task.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ def schedule_next_task(interval = execution_interval)
# @!visibility private
def execute_task(completion)
return nil unless @running.true?
ScheduledTask.execute(execution_interval, args: [completion], &method(:timeout_task))
ScheduledTask.execute(timeout_interval, args: [completion], &method(:timeout_task))
_success, value, reason = @executor.execute(self)
if completion.try?
self.value = value
Expand Down
2 changes: 1 addition & 1 deletion spec/concurrent/timer_task_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def trigger_observable(observable)
end

it 'notifies all observers on timeout' do
subject = TimerTask.new(execution: 0.1, timeout: 0.1) { sleep }
subject = TimerTask.new(run_now: true, execution: 2, timeout: 0.1) { sleep }
subject.add_observer(observer)
subject.execute
observer.latch.wait(1)
Expand Down