Merge pull request #680 from olleolleolle/fix/update-rspec

Avoid RSpec monkey patching, persist spec results locally, use RSpec v3.7.0

Author: pitr-ch

.gitignore

@@ -24,3 +24,5 @@ tmtags
 # junk
 .DS_Store
 .githubtoken
+
+spec/examples.txt

Gemfile

@@ -20,7 +20,7 @@ group :development do
 end
 
 group :testing do
-  gem 'rspec', '~> 3.3.0'
+  gem 'rspec', '~> 3.7'
   gem 'timecop', '~> 0.7.4'
 end
 

spec/concurrent/actor_spec.rb

@@ -6,7 +6,7 @@ module Actor
 
     # FIXME better tests!
 
-    describe 'Concurrent::Actor', edge: true, if: !defined?(JRUBY_VERSION) do
+    RSpec.describe 'Concurrent::Actor', edge: true, if: !defined?(JRUBY_VERSION) do
 
       def terminate_actors(*actors)
         actors.each do |actor|

spec/concurrent/agent_spec.rb

@@ -2,7 +2,7 @@
 
 module Concurrent
 
-  describe Agent do
+  RSpec.describe Agent do
 
     let!(:immediate) { Concurrent::ImmediateExecutor.new }
     let!(:executor) { Concurrent::SingleThreadExecutor.new }

spec/concurrent/array_spec.rb

@@ -1,5 +1,5 @@
 module Concurrent
-  describe Array do
+  RSpec.describe Array do
     let!(:ary) { described_class.new }
 
     it 'concurrency' do

spec/concurrent/async_spec.rb

@@ -1,6 +1,6 @@
 module Concurrent
 
-  describe Async do
+  RSpec.describe Async do
 
     let(:async_class) do
       Class.new do

spec/concurrent/atom_spec.rb

@@ -2,7 +2,7 @@
 
 module Concurrent
 
-  describe Atom do
+  RSpec.describe Atom do
 
     context 'construction' do
 

spec/concurrent/atomic/atomic_boolean_spec.rb

@@ -1,4 +1,4 @@
-shared_examples :atomic_boolean do
+RSpec.shared_examples :atomic_boolean do
 
   describe 'construction' do
 
@@ -104,7 +104,7 @@
 
 module Concurrent
 
-  describe MutexAtomicBoolean do
+  RSpec.describe MutexAtomicBoolean do
 
     it_should_behave_like :atomic_boolean
 
@@ -142,19 +142,19 @@ module Concurrent
 
   if defined? Concurrent::CAtomicBoolean
 
-    describe CAtomicBoolean, ext: true do
+    RSpec.describe CAtomicBoolean, ext: true do
       it_should_behave_like :atomic_boolean
     end
   end
 
   if Concurrent.on_jruby?
 
-    describe JavaAtomicBoolean do
+    RSpec.describe JavaAtomicBoolean do
       it_should_behave_like :atomic_boolean
     end
   end
 
-  describe AtomicBoolean do
+  RSpec.describe AtomicBoolean do
     if RUBY_ENGINE != 'ruby'
       it 'does not load the C extension' do
         expect(defined?(Concurrent::CAtomicBoolean)).to be_falsey

spec/concurrent/atomic/atomic_fixnum_spec.rb

@@ -1,4 +1,4 @@
-shared_examples :atomic_fixnum do
+RSpec.shared_examples :atomic_fixnum do
 
   context 'construction' do
 
@@ -153,7 +153,7 @@
 
 module Concurrent
 
-  describe MutexAtomicFixnum do
+  RSpec.describe MutexAtomicFixnum do
 
     it_should_behave_like :atomic_fixnum
 
@@ -202,19 +202,19 @@ module Concurrent
 
   if defined? Concurrent::CAtomicFixnum
 
-    describe CAtomicFixnum, ext: true do
+    RSpec.describe CAtomicFixnum, ext: true do
       it_should_behave_like :atomic_fixnum
     end
   end
 
   if Concurrent.on_jruby?
 
-    describe JavaAtomicFixnum do
+    RSpec.describe JavaAtomicFixnum do
       it_should_behave_like :atomic_fixnum
     end
   end
 
-  describe AtomicFixnum do
+  RSpec.describe AtomicFixnum do
     if RUBY_ENGINE != 'ruby'
       it 'does not load the C extension' do
         expect(defined?(Concurrent::CAtomicFixnum)).to be_falsey

spec/concurrent/atomic/atomic_markable_reference_spec.rb

@@ -1,4 +1,4 @@
-describe Concurrent::Edge::AtomicMarkableReference do
+RSpec.describe Concurrent::Edge::AtomicMarkableReference do
   subject { described_class.new 1000, true }
 
   describe '.initialize' do