Merge pull request #14418 from koic/fix_false_positives_for_style_map_to_set

Fix false positives for `Style/MapToSet`

Author: koic

changelog/fix_false_positives_for_style_map_to_set.md

@@ -0,0 +1 @@
+* [#14418](https://github.com/rubocop/rubocop/pull/14418): Fix false positives for `Style/MapToSet` when using `to_set` with block argument. ([@koic][])

lib/rubocop/cop/style/map_to_set.rb

@@ -40,12 +40,10 @@ class MapToSet < Base
 
         def on_send(node)
           return unless (to_set_node, map_node = map_to_set?(node))
+          return if to_set_node.block_literal?
 
           message = format(MSG, method: map_node.loc.selector.source)
           add_offense(map_node.loc.selector, message: message) do |corrector|
-            # If the `to_set` call already has a block, do not autocorrect.
-            next if to_set_node.block_literal?
-
             autocorrect(corrector, to_set_node, map_node)
           end
         end

spec/rubocop/cop/style/map_to_set_spec.rb

@@ -116,14 +116,27 @@
       end
     end
 
-    context "`#{method}.to_set` with a block on `to_set`" do
-      it 'registers an offense but does not correct' do
-        expect_offense(<<~RUBY, method: method)
+    context "`#{method}` followed by `to_set` with a block passed to `to_set`" do
+      it 'does not register an offense but does not correct' do
+        expect_no_offenses(<<~RUBY)
+          foo.#{method} { |x| x * 2 }.to_set { |x| [x.to_s, x] }
+        RUBY
+      end
+    end
+
+    context "`#{method}` followed by `to_set` with a numbered block passed to `to_set`", :ruby27 do
+      it 'does not register an offense but does not correct' do
+        expect_no_offenses(<<~RUBY)
           foo.#{method} { |x| x * 2 }.to_set { |x| [x.to_s, x] }
-              ^{method} Pass a block to `to_set` instead of calling `#{method}.to_set`.
         RUBY
+      end
+    end
 
-        expect_no_corrections
+    context "`#{method}` followed by `to_set` with an `it` block passed to `to_set`", :ruby34 do
+      it 'does not register an offense but does not correct' do
+        expect_no_offenses(<<~RUBY)
+          foo.#{method} { |x| x * 2 }.to_set { |x| [x.to_s, x] }
+        RUBY
       end
     end