Fix crash on cancelling the File->New dialog #275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of patch #220 . |
Merged
rowanj
pushed a commit
that referenced
this pull request
Jul 27, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I want to open a recent window, I often hit ⌘N � ⎋ without thinking about it, which causes a crash as AppKit inspects the uninitialized
outErrorto find out why PBRepositoryDocumentController didn't create a document.This commit fixes the crash. You now get "No document could be created." on hitting File->New, then Cancel - it appears to be impossible to silently return nil from
makeUntitledDocumentOfType.