fix(commonjs): crawl dynamicRequireRoot outside cwd (#1859)

* test(commonjs): add failing test for dynamicRequireRoot outside cwd

* fix(commonjs): dynamicRequireRoot outside cwd

Author: ambarvm

packages/commonjs/src/dynamic-modules.js

@@ -1,5 +1,5 @@
 import { existsSync, readFileSync, statSync } from 'fs';
-import { join, resolve, dirname } from 'path';
+import { join, resolve, dirname, relative } from 'path';
 
 import getCommonDir from 'commondir';
 
@@ -46,7 +46,7 @@ export function getDynamicRequireModules(patterns, dynamicRequireRoot) {
       .withBasePath()
       .withDirs()
       .glob(isNegated ? pattern.substr(1) : pattern)
-      .crawl()
+      .crawl(relative('.', dynamicRequireRoot))
       .sync()
       .sort((a, b) => a.localeCompare(b, 'en'))) {
       const resolvedPath = resolve(path);

packages/commonjs/test/fixtures/samples/dynamic-require-root-outside-cwd/cwd/main.js

@@ -0,0 +1,6 @@
+function takeModule(path) {
+  // eslint-disable-next-line global-require,import/no-dynamic-require
+  return require(path);
+}
+
+takeModule('../outer.js');

packages/commonjs/test/fixtures/samples/dynamic-require-root-outside-cwd/outer.js

@@ -0,0 +1 @@
+module.exports = 'outer_export_value';

packages/commonjs/test/test-dynamic-require-root-outside-cwd.js

@@ -0,0 +1,23 @@
+const path = require('path');
+
+const test = require('ava');
+const { rollup } = require('rollup');
+
+const { commonjs } = require('./helpers/util.js');
+
+process.chdir(path.join(__dirname, 'fixtures/samples/dynamic-require-root-outside-cwd/cwd'));
+
+test('crawls dynamicRequireRoot outside cwd', async (t) => {
+  const build = await rollup({
+    input: 'main.js',
+    plugins: [
+      commonjs({
+        dynamicRequireRoot: '..',
+        dynamicRequireTargets: ['../outer.js']
+      })
+    ]
+  });
+  const bundle = await build.generate({ format: 'cjs' });
+  const { code } = bundle.output[0];
+  t.true(code.includes('outer_export_value'), 'outer_export_value not found in the code');
+});