Skip to content

Fix placeholder for russian translation #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2019
Merged

Fix placeholder for russian translation #27

merged 3 commits into from
Mar 4, 2019

Conversation

@vkhramtsov
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

@vkhramtsov
Copy link
Contributor Author

Unfortunately I have to add symfony/translation as dependency, because symfony/validator 4.2.* does not require it anymore.

@vkhramtsov
Copy link
Contributor Author

@sstok Would you be so kind to review/merge this fix?

@sstok sstok added the Bug label Mar 4, 2019
sstok
sstok approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@sstok sstok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. I forgot I disabled e-mail notifcations and use Octobox now.

@sstok sstok merged commit e94ae9c into rollerworks:master Mar 4, 2019
@sstok
Copy link
Member

sstok commented Mar 4, 2019

Thank you @vkhramtsov

@vkhramtsov vkhramtsov deleted the bugfix-placeholder-in-russian-translation branch March 4, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sstok sstok sstok approved these changes

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vkhramtsov @sstok