Skip to content

Conversation

@gnat42
Copy link
Contributor

@gnat42 gnat42 commented Mar 20, 2018

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
License MIT

Added the translations for the validator. All translations done via Google Translate...

@sstok
Copy link
Member

sstok commented Mar 26, 2018

What do think of Password was found {{ used }} times in a database of compromised passwords. Use a different a password. as translated string?

The original message was personalized which was a mistake as the password may not be the password of the actual user (Administrator changing a user's password for example).
We need leave the original translator strings though as this is considered a BC break 😞

@stof
Copy link
Contributor

stof commented Apr 26, 2018

It would be even better if the validator could provide the number of usages as the pluralization number, to allow proper pluralization. In English or French, always using a plural may seem fine as numbers may likely be >= 2, but other locales may have much more complex rules (look at Russian for instance).

@sstok
Copy link
Member

sstok commented Dec 1, 2019

Given this is now supported by Symfony itself should this pr be closed, and the validator in this repository be deprecated in favor of the Symfony one?

@sstok sstok force-pushed the pwnedpassword-translation branch from 9a92d44 to 410cb9a Compare May 19, 2021 08:48
@sstok sstok merged commit 1d36f95 into rollerworks:main May 19, 2021
@sstok
Copy link
Member

sstok commented May 19, 2021

Sorry for the late merge. I'm merging this so we can move forward, as this feature is now part of the Symfony core it will be deprecated in another pr. Thanks for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants