Skip to content

Conversation

hardikdava
Copy link
Contributor

Description

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

Load coco128 dataset which contains images but not annotations. This represents background image. Supervision is eliminating such cases.

@SkalskiP
Copy link
Collaborator

@hardikdava, let me know when you'll be ready for review here.

@hardikdava
Copy link
Contributor Author

@SkalskiP the fix is added. Please review it and merge it.

@SkalskiP SkalskiP added the bug Something isn't working label Jul 23, 2023
@SkalskiP SkalskiP added this to the version: 0.12.0 milestone Jul 23, 2023
@SkalskiP
Copy link
Collaborator

@hardikdava I'm testing now. If I understand correctly, before that change, coco128.yaml should load only 126 entries, and after, we should have 128.

@hardikdava
Copy link
Contributor Author

@hardikdava I'm testing now. If I understand correctly, before that change, coco128.yaml should load only 126 entries, and after, we should have 128.

Yeah, 128 is expected result.

@SkalskiP
Copy link
Collaborator

@hardikdava tested! Merging.

@SkalskiP SkalskiP merged commit 97ae155 into roboflow:main Jul 23, 2023
@SkalskiP SkalskiP added the version: 0.12.0 Feature to be added in `0.12.0` release label Jul 31, 2023
@SkalskiP SkalskiP self-requested a review July 31, 2023 20:56
@hardikdava hardikdava deleted the fix/yolo_loading_bug branch August 10, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working version: 0.12.0 Feature to be added in `0.12.0` release
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants