Skip to content

Commit 10f58be

Browse files
authored
Adding support for a different domain than GitHub.com (#110)
* Update package.json * Add REACT_APP_GITHUB_DOMAIN
1 parent 2585a0c commit 10f58be

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,8 @@ React and Apollo dev tools will be available inside the Chrome dev tools.
6969

7070
Pullp uses an external auth server to complete Github sign in and receive a token for the Github API. You may want to host a local version of this server. Clone it from https://github.com/rkclark/pullp-oauth-gatekeeper, run it on the port of your choosing and then add the server URL to `REACT_APP_OAUTH_GATEKEEPER_URL` in the `/env/.env.development` file inside of Pullp.
7171

72+
If you are connecting to a different GitHub domain than `github.com`, you can set `REACT_APP_GITHUB_DOMAIN` to that domain such as `github.mycompany.com`
73+
7274
Your oauth server will need set of Github oAuth app credentials. To make these:
7375

7476
* In Github, go to your settings

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "pullp",
3-
"version": "3.0.0",
3+
"version": "3.0.1",
44
"private": false,
55
"main": "public/electron-starter.js",
66
"license": "MIT",

public/electron-starter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ function createMainWindow() {
5858
});
5959

6060
const handleRedirect = (e, navUrl) => {
61-
if (navUrl.includes('github.com')) {
61+
if (navUrl.includes(process.env.REACT_APP_GITHUB_DOMAIN || 'github.com')) {
6262
e.preventDefault();
6363
shell.openExternal(navUrl);
6464
}

0 commit comments

Comments
 (0)