WIP Fixed observer pool for hooks #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding observer to the pool when it's created rather than we have an element to observe
saitonakamura
changed the title
Rendez
approved these changes
Aug 4, 2020
researchgate-bot
pushed a commit
that referenced
this pull request
Aug 4, 2020
## [1.3.2](v1.3.1...v1.3.2) (2020-08-04) ### Bug Fixes * observer pool for hooks ([#153](#153)) ([807b8df](807b8df))
|
🎉 This PR is included in version 1.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
saitonakamura
added a commit
to saitonakamura/react-intersection-observer
that referenced
this pull request
Nov 3, 2020
When new element already holds a ref to an observer and the previous element (that used the same observer) unobserves, it creates a broken state when that observer is deleted from map, but new element holds that ref and thinks it's ok to observe Essentially i'm bringing back part of the code deleted in researchgate#153, namely https://github.com/researchgate/react-intersection-observer/pull/153/files#diff-44cb04e2627c3ab84281b41d14880e5e822437f19144e8c14a6c95f7f7fa14bbL72 I also added tests to not to break this and researchgate#153 in the future
9 tasks
danez
pushed a commit
that referenced
this pull request
Nov 4, 2020
When new element already holds a ref to an observer and the previous element (that used the same observer) unobserves, it creates a broken state when that observer is deleted from map, but new element holds that ref and thinks it's ok to observe Essentially i'm bringing back part of the code deleted in #153, namely https://github.com/researchgate/react-intersection-observer/pull/153/files#diff-44cb04e2627c3ab84281b41d14880e5e822437f19144e8c14a6c95f7f7fa14bbL72 I also added tests to not to break this and #153 in the future
researchgate-bot
pushed a commit
that referenced
this pull request
Nov 4, 2020
## [1.3.5](v1.3.4...v1.3.5) (2020-11-04) ### Bug Fixes * **observer:** fix of reobserve doesn't add observer to map ([3ce4536](3ce4536)), closes [#153](#153) [/github.com//pull/153/files#diff-44cb04e2627c3ab84281b41d14880e5e822437f19144e8c14a6c95f7f7fa14bbL72](https://github.com//github.com/researchgate/react-intersection-observer/pull/153/files/issues/diff-44cb04e2627c3ab84281b41d14880e5e822437f19144e8c14a6c95f7f7fa14bbL72) [#153](#153)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
By adding observer to the pool when it's created rather than we have an
element to observe
Motivation and context
Fixes #152
How has this been tested?
yarn lint && yarn testand storybook manual testingType of change
Checklist: