Skip to content

Commit 58a8d45

Browse files
committed
rptest: stop() in nodes_decommissioning_test
1 parent 2e08279 commit 58a8d45

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

tests/rptest/tests/nodes_decommissioning_test.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -308,17 +308,19 @@ def verify(self):
308308
f"verifying workload: topic: {self._topic}, with [rate_limit: {self.producer_throughput}, message size: {self.msg_size}, message count: {self.msg_count}]"
309309
)
310310
self.producer.wait()
311+
self.producer.stop()
311312

312313
# Await the consumer that is reading only the subset of data that
313314
# was written before it started.
314315
self.consumer.wait()
315-
316+
self.consumer.stop()
316317
assert self.consumer.consumer_status.validator.invalid_reads == 0, f"Invalid reads in topic: {self._topic}, invalid reads count: {self.consumer.consumer_status.validator.invalid_reads}"
317318
del self.consumer
318319

319320
# Start a new consumer to read all data written
320321
self.start_consumer()
321322
self.consumer.wait()
323+
self.consumer.stop()
322324

323325
assert self.consumer.consumer_status.validator.invalid_reads == 0, f"Invalid reads in topic: {self._topic}, invalid reads count: {self.consumer.consumer_status.validator.invalid_reads}"
324326

@@ -490,7 +492,6 @@ def calculate_total_learners_gap() -> int | None:
490492

491493
self.logger.info(f"decommissioning node: {to_decommission_id}", )
492494
self._decommission(to_decommission_id)
493-
self.producer.wait()
494495

495496
def learner_gap_reported(decommissioned_node_id: int):
496497
total_gap = calculate_total_learners_gap()
@@ -1337,6 +1338,7 @@ def hmb(bs):
13371338
return [convert(b) for b in bs]
13381339

13391340
producer.wait(timeout_sec=300)
1341+
producer.stop()
13401342
produce_duration = time.time() - produce_start_time
13411343
self.logger.info(
13421344
f"Produced {hmb([data_size])} in {produce_duration} seconds")

0 commit comments

Comments
 (0)