Included ZCARD and HMGET tests (#144)

Author: filipecosta90

.gitignore

@@ -1,5 +1,6 @@
 # work files
 *.csv
+utils/tests/test_data/dump.rdb
 
 # mac
 

redis_benchmarks_specification/test-suites/memtier_benchmark-1Mkeys-hash-hmget-5-fields-with-100B-values-pipeline-10.yml

@@ -0,0 +1,37 @@
+version: 0.4
+name: memtier_benchmark-1Mkeys-hash-hmget-5-fields-with-100B-values-pipeline-10
+description: Runs memtier_benchmark, for a keyspace length of 1M keys pre-loading HASHes in which the value has a data size of 100 Bytes. After pre-loading the data it issues HMGET command retrieving all fields of the hash.
+dbconfig:
+  configuration-parameters:
+    save: '""'
+  preload_tool:
+    run_image: redislabs/memtier_benchmark:edge
+    tool: memtier_benchmark
+    arguments: '"--data-size" "100" --command "HSET __key__ field1 __data__ field2 __data__ field3 __data__ field4 __data__ field5 __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 10000000 -n 5000 -c 50 -t 4 --hide-histogram'
+tested-groups:
+- hash
+tested-commands:
+- hmget
+redis-topologies:
+- oss-standalone
+build-variants:
+- gcc:8.5.0-amd64-debian-buster-default
+clientconfig:
+  run_image: redislabs/memtier_benchmark:edge
+  tool: memtier_benchmark
+  arguments: '--pipeline 10 --command "HMGET __key__ field1 field2 field3 field4 field5" --command-key-pattern="R" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
+  resources:
+    requests:
+      cpus: '4'
+      memory: 2g
+exporter:
+  redistimeseries:
+    break_by:
+    - version
+    - commit
+    timemetric: $."ALL STATS".Runtime."Start time"
+    metrics:
+    - $."ALL STATS".Totals."Ops/sec"
+    - $."ALL STATS".Totals."Latency"
+    - $."ALL STATS".Totals."Misses/sec"
+    - $."ALL STATS".Totals."Percentile Latencies"."p50.00"

redis_benchmarks_specification/test-suites/memtier_benchmark-1key-zset-1M-elements-zcard-pipeline-10.yml

@@ -0,0 +1,37 @@
+version: 0.4
+name: memtier_benchmark-1key-zset-1M-elements-zcard-pipeline-10
+description: 'Runs memtier_benchmark, for a keyspace length of 1 SORTED SET key. The SORTED SET contains 1M elements in it and we query it using ZCARD.'
+dbconfig:
+  configuration-parameters:
+    save: '""'
+  preload_tool:
+    run_image: redislabs/memtier_benchmark:edge
+    tool: memtier_benchmark
+    arguments: --key-maximum 1000000 --key-prefix "" --command="ZADD lb __key__ __key__"  --command-key-pattern P --hide-histogram -t 4 -c 100
+tested-groups:
+- sorted-set
+tested-commands:
+- zcard
+redis-topologies:
+- oss-standalone
+build-variants:
+- gcc:8.5.0-amd64-debian-buster-default
+clientconfig:
+  run_image: redislabs/memtier_benchmark:edge
+  tool: memtier_benchmark
+  arguments: --command="ZCARD lb"  --hide-histogram --test-time 180 --pipeline 10
+  resources:
+    requests:
+      cpus: '4'
+      memory: 2g
+exporter:
+  redistimeseries:
+    break_by:
+    - version
+    - commit
+    timemetric: $."ALL STATS".Runtime."Start time"
+    metrics:
+    - $."ALL STATS".Totals."Ops/sec"
+    - $."ALL STATS".Totals."Latency"
+    - $."ALL STATS".Totals."Misses/sec"
+    - $."ALL STATS".Totals."Percentile Latencies"."p50.00"

utils/tests/test_data/dump.rdb

@@ -31,6 +31,7 @@
 )
 from redis_benchmarks_specification.__setups__.topologies import get_topologies
 from utils.tests.test_data.api_builder_common import flow_1_and_2_api_builder_checks
+from utils.tests.test_self_contained_coordinator_memtier import rdb_load_in_tests
 
 
 def test_extract_client_cpu_limit():
@@ -98,15 +99,10 @@ def test_self_contained_coordinator_blocking_read():
         if run_coordinator:
             conn = redis.StrictRedis(port=16379)
             conn.ping()
-            use_rdb = True
-            TST_RUNNER_USE_RDB = os.getenv("TST_RUNNER_USE_RDB", "1")
             build_variant_name = "gcc:8.5.0-amd64-debian-buster-default"
             expected_datapoint_ts = None
-            if TST_RUNNER_USE_RDB == "0":
-                use_rdb = False
-            if use_rdb:
-                conn.execute_command("DEBUG", "RELOAD", "NOSAVE")
-            else:
+            use_rdb = rdb_load_in_tests(conn)
+            if use_rdb is False:
                 conn.flushall()
                 build_variant_name, reply_fields = flow_1_and_2_api_builder_checks(conn)
                 if b"git_timestamp_ms" in reply_fields:
@@ -270,9 +266,6 @@ def test_self_contained_coordinator_blocking_read():
             assert len(datasink_conn.smembers(testcases_setname)) == 1
             assert len(datasink_conn.smembers(project_branches_setname)) == 1
             assert len(datasink_conn.smembers(project_versions_setname)) == 0
-            # ensure we don't change state on the rdb
-            if use_rdb:
-                conn.execute_command("DEBUG", "RELOAD", "NOSAVE")
 
     except redis.exceptions.ConnectionError:
         pass

utils/tests/test_self_contained_coordinator.py

@@ -37,15 +37,10 @@ def test_self_contained_coordinator_blocking_read():
         if run_coordinator:
             conn = redis.StrictRedis(port=16379)
             conn.ping()
-            use_rdb = True
-            TST_RUNNER_USE_RDB = os.getenv("TST_RUNNER_USE_RDB", "1")
             build_variant_name = "gcc:8.5.0-amd64-debian-buster-default"
             expected_datapoint_ts = None
-            if TST_RUNNER_USE_RDB == "0":
-                use_rdb = False
-            if use_rdb:
-                conn.execute_command("DEBUG", "RELOAD", "NOSAVE")
-            else:
+            use_rdb = rdb_load_in_tests(conn)
+            if use_rdb is False:
                 conn.flushall()
                 build_variant_name, reply_fields = flow_1_and_2_api_builder_checks(conn)
                 if b"git_timestamp_ms" in reply_fields:
@@ -200,6 +195,23 @@ def test_self_contained_coordinator_blocking_read():
         pass
 
 
+def rdb_load_in_tests(conn):
+    use_rdb = True
+    TST_RUNNER_USE_RDB = os.getenv("TST_RUNNER_USE_RDB", "1")
+    if TST_RUNNER_USE_RDB == "0":
+        use_rdb = False
+    if use_rdb:
+        try:
+            conn.execute_command("DEBUG", "RELOAD", "NOSAVE")
+        except redis.exceptions.ResponseError as e:
+            if "DEBUG command not allowed" in e.__str__():
+                use_rdb = False
+                pass
+            else:
+                raise e
+    return use_rdb
+
+
 def test_self_contained_coordinator_skip_build_variant():
     try:
         run_coordinator = True
@@ -209,15 +221,10 @@ def test_self_contained_coordinator_skip_build_variant():
         if run_coordinator:
             conn = redis.StrictRedis(port=16379)
             conn.ping()
-            use_rdb = True
-            TST_RUNNER_USE_RDB = os.getenv("TST_RUNNER_USE_RDB", "1")
             build_variant_name = "gcc:8.5.0-amd64-debian-buster-default"
             expected_datapoint_ts = None
-            if TST_RUNNER_USE_RDB == "0":
-                use_rdb = False
-            if use_rdb:
-                conn.execute_command("DEBUG", "RELOAD", "NOSAVE")
-            else:
+            use_rdb = rdb_load_in_tests(conn)
+            if use_rdb is False:
                 conn.flushall()
                 build_variant_name, reply_fields = flow_1_and_2_api_builder_checks(conn)
                 if b"git_timestamp_ms" in reply_fields: