[BREAKING CHANGE 🚨] Remove support for Lumen

[mfn]

Summary

Supporting Lumen without a dedicated framework for testing is a nightmare, any kind of fixes or changes are hard to verify. Also the readme never went beyond calling it "experimental".

So far the issues could be resolved, but due to it's niche application there are not many active contributions going on. And before Lumen supports jump on board, this project could rather use regular maintainers for the library and it's Laravel integration itself first and foremost.

The goal is to free this library from these requirements and allow it's further evolution without having to think about Lumen.

This PR targets the next major release due to this breaking change. I encourage everyone requiring Lumen support of this library to create a fork.

---

Type of change:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

• Existing tests have been adapted and/or new tests have been added
• Add a CHANGELOG.md entry
• Update the README.md
• Code style has been fixed via composer fix-style

Links

• Fixes multiple schema on lumen not find query or mutation #568

[mfn]

@pierlon you made #188 , are you still using Lumen + graphql-laravel ?

Supporting Lumen over the last two years was the second most source of issues people reported and since there will never be a properly testing framework for it, I'm aiming for removing it.

[pierlon]

@mfn No I no longer use it. It's unfortunate that it has caused so many issues but do feel free to remove it 🙂.

[mfn]

Pinging past contributors with Lumen specific code for awareness and feedback: @ulrichdahl @sglitowitzsoci @jstoks

Two ppl not pinged here already stated they're not using Lumen anymore (including the original author, see #722 (comment) )

[ulrichdahl]

@mfn I use Lumen and this in many projects. If you will no longer maintain it for Lumen I will fork it and maintain my own fork.

[mfn]

Thanks @ulrichdahl for your feedback!

Although I did anticipate ppl will just fork it, seeing it might indeed happen makes me feel a bit different about it.

I'll think a bit more about it and will not include remove it in the next major version.

[ulrichdahl]

@mfn I have actually changed my position since last 😄 so I am actually busy migrating all my projects to Laravel. Turns out that it is rather simple, only few hours of work is needed per project. Thank god it is simple projects.
Only 1 of them may stay in Lumen, but it is only a maybe. So could turn out to be ok for me too, right now I do not think I will fork anyway.

But it looks like @artem-schander has forked and is changing it to be more Lumen ready out of the box.
EdwinDayot@c3ece72

[artem-schander]

I'm alright. The few Lumen projects will be migrated to Laravel soon. But thanks for considering.

[mfn]

I have actually changed my position since last 😄

oh my, I'm glad I asked 😅

I'm well aware the people I pinged here don't reflect the real user base, but since we don't have many regular contributors, I was only concern with anyone who invested something in the project.

I'm putting the PR back on track and merging it now.

---

For anyone arriving later here affected by this:

• please consider moving to Laravel
  • try to empathize the the work you need to invest for the switch (one time) vs. this project needs (long term)
  • TBH also seeing how seemingly easy ppl are able/willing/can switch to Lumen just relaxes by doubts about this move
• I'm not rejecting the idea to add support for it back in the future
  • But as I stated multiple times, the debt for it is unusually higher because there's no built-in way (like orchestra) to test things.
  • Right now my goal is to have a codebase I can understand and maintain, and the Lumen stuff doesn't help

I personally also think that the need for something like Lumen with the state of PHP 2021 isn't really there. It's not a coincidence there's a decline of contributions to https://github.com/laravel/lumen vs. the hype about different architectures like https://github.com/laravel/octane/ . I would rather make sure this library plays well with the latter than the former.

Thanks everyone for your feedback! 🙏

---

Edit: also see this tweet from Taylor:

I get a fair amount of questions about Lumen. If you need a little speed boost over plain Laravel (be sure that you actually need this first!), then I suggest using Laravel + Octane. 🚀

That combination is faster than Lumen.