Remove support for Lumen

Supporting Lumen without a dedicated framework for testing is a nightmare,
so many unresolved issues and very few contributions over the years led
me to believe we're better off removing support.

The readme never went beyond calling it "experimental".

This PR targets the next major release due to this breaking change.

Author: mfn

.github/ISSUE_TEMPLATE/1_Bug_report.md

@@ -8,7 +8,6 @@ labels: bug
 ### Versions:
 - graphql-laravel Version: #.#.#
 - Laravel Version: #.#.# <!-- remove if not applicable -->
-- Lumen Version: #.#.# <!-- remove if not applicable -->
 - PHP Version: #.#.#
 
 ### Description:

.github/ISSUE_TEMPLATE/3_Support_question.md

@@ -11,7 +11,6 @@ Alternative you can also use our Slack workspace: https://join.slack.com/t/rebin
 ### Versions:
 - graphql-laravel Version: #.#.#
 - Laravel Version: #.#.# <!-- remove if not applicable -->
-- Lumen Version: #.#.# <!-- remove if not applicable -->
 - PHP Version: #.#.#
 
 ### Question:

.github/workflows/integration_tests.yml

@@ -18,11 +18,7 @@ on:
 
 jobs:
   integration:
-    strategy:
-      fail-fast: false
-      matrix:
-        integration: [laravel, lumen]
-    name: ${{ matrix.integration }}
+    name: laravel
     runs-on: ubuntu-20.04
     env:
       COMPOSER_NO_INTERACTION: 1
@@ -53,4 +49,4 @@ jobs:
 
       - run: composer install --prefer-dist --no-suggest
 
-      - run: tests/integration-${{ matrix.integration }}.sh
+      - run: tests/integration-laravel.sh

CHANGELOG.md

@@ -5,6 +5,7 @@ CHANGELOG
 --------------
 
 ## Breaking changes
+- Support for Lumen has been removed
 - Integrate laragraph/utils RequestParser [\#739 / mfn](https://github.com/rebing/graphql-laravel/pull/739)
   - batched queries will only work with `POST` requests
     This is due to `RequestParser` using `\GraphQL\Server\Helper::parseRequestParams` which includes this check

README.md

@@ -32,7 +32,7 @@ It offers following features and improvements over the original package by
 
 ### Dependencies:
 
-* [Laravel 6.0+](https://github.com/laravel/laravel) or [Lumen](https://github.com/laravel/lumen)
+* [Laravel 6.0+](https://github.com/laravel/laravel)
 * [GraphQL PHP](https://github.com/webonyx/graphql-php)
 
 
@@ -55,37 +55,7 @@ Review the configuration file:
 config/graphql.php
 ```
 
-#### Lumen (experimental!)
-
-**1.** Add the following service provider to the `bootstrap/app.php` file
-```php
-$app->register(Rebing\GraphQL\GraphQLLumenServiceProvider::class);
-```
-
-**2.** Publish the configuration file
-```bash
-$ php artisan graphql:publish
-```
-
-**3.** Add the configuration to the `bootstrap/app.php` file
-    *Important:* this needs to be before the registration of the service provider
-```php
-$app->configure('graphql');
-...
-$app->register(Rebing\GraphQL\GraphQLLumenServiceProvider::class);
-```
-
-**4.** Review the configuration file
-```php
-config/graphql.php
-```
-
 The default GraphiQL view makes use of the global `csrf_token()` helper function.
-Out of the box, this function is not available in Lumen.
-
-To work this around:
-- Point to your local GraphiQL view: change `graphql.view` to `'vendor/graphql/graphiql'`
-- Modify your file `resources/views/vendor/graphql/graphiql.php` and remove the call
 
 ## Usage
 
@@ -94,7 +64,6 @@ To work this around:
       - [Dependencies:](#dependencies)
       - [Installation:](#installation)
         - [Laravel 6.0+](#laravel)
-        - [Lumen (experimental!)](#lumen-experimental)
   - [Usage](#usage)
     - [Concepts](#concepts)
     - [Data loading](#data-loading)

phpstan-baseline.neon

@@ -455,26 +455,11 @@ parameters:
 			count: 1
 			path: src/Support/UploadType.php
 
-		-
-			message: "#^Call to method get\\(\\) on an unknown class Laravel\\\\Lumen\\\\Routing\\\\Router\\.$#"
-			count: 3
-			path: src/routes.php
-
-		-
-			message: "#^Call to method post\\(\\) on an unknown class Laravel\\\\Lumen\\\\Routing\\\\Router\\.$#"
-			count: 3
-			path: src/routes.php
-
 		-
 			message: "#^PHPDoc tag @var for variable \\$queryTypesMap has no value type specified in iterable type array\\.$#"
 			count: 1
 			path: src/routes.php
 
-		-
-			message: "#^PHPDoc tag @var for variable \\$router contains unknown class Laravel\\\\Lumen\\\\Routing\\\\Router\\.$#"
-			count: 2
-			path: src/routes.php
-
 		-
 			message: "#^Parameter \\#2 \\$callback of function array_filter expects \\(callable\\(mixed, mixed\\)\\: bool\\)\\|null, Closure\\(array, string\\)\\: bool\\|null given\\.$#"
 			count: 1

src/GraphQL.php

@@ -466,12 +466,6 @@ public static function routeNameTransformer(string $name, string $schemaParamete
         $routeName = null;
 
         if (count($multiLevelPath) > 1) {
-            if (Helpers::isLumen()) {
-                array_walk($multiLevelPath, function (string &$multiName): void {
-                    $multiName = "$multiName:$multiName";
-                });
-            }
-
             foreach ($multiLevelPath as $multiName) {
                 $routeName = !$routeName ? null : $routeName . '/';
                 $routeName =
@@ -480,7 +474,7 @@ public static function routeNameTransformer(string $name, string $schemaParamete
             }
         }
 
-        return $routeName ?: preg_replace($schemaParameterPattern, '{' . (Helpers::isLumen() ? "schema:$name" : $name) . '}', $queryRoute);
+        return $routeName ?: preg_replace($schemaParameterPattern, '{' . $name . '}', $queryRoute);
     }
 
     /**

src/GraphQLController.php

@@ -36,7 +36,7 @@ public function query(Request $request, string $schemaName = null): JsonResponse
 
         // If there are multiple route params we can expect that there
         // will be a schema name that has to be built
-        $routeParameters = $this->getRouteParameters($request);
+        $routeParameters = $request->route()->parameters;
 
         if (count($routeParameters) > 1) {
             $schemaName = implode('/', $routeParameters);
@@ -194,21 +194,6 @@ public function graphiql(Request $request, string $schemaName = null): View
         ]);
     }
 
-    /**
-     * @return array<string,string>
-     */
-    protected function getRouteParameters(Request $request): array
-    {
-        if (Helpers::isLumen()) {
-            /** @var array<int,mixed> $route */
-            $route = $request->route();
-
-            return $route[2] ?? [];
-        }
-
-        return $request->route()->parameters;
-    }
-
     /**
      * In case batching is not supported, send an error back for each batch
      * (with a hardcoded limit of 100).

src/GraphQLLumenServiceProvider.php

@@ -7,11 +7,6 @@
 
 class Helpers
 {
-    public static function isLumen(): bool
-    {
-        return class_exists('Laravel\Lumen\Application');
-    }
-
     /**
      * Originally from \Nuwave\Lighthouse\Support\Utils::applyEach
      *