Should we release 0.67.3?

[ShikaSD]

Current Release: 0.67.2

Conversations on this thread are limited:

• major release issues
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issue, please reference the issue here.

---

List of qualified picks

1. facebook/react-native@1a83dc3
2. facebook/react-native@c1db41f

Local commits to backport to main

[billnbell]

upgrade helper is not there for 0.67.2 -- ??

[kelset]

Thanks for reporting! I've generated it now, if you open the upgrade-helper now you should see 0.67.2 there :)

(I think I might have an idea of why it wasn't automatically generated, I'll look more into it...)

[kmsbernard]

I suggest to cherry-pick facebook/react-native@1a83dc3, fix a broken text input in Korean language on iOS 15

[lunaleaps]

Pick request: facebook/react-native@c1db41f

• Fixes the infinite loop explained in the issue [Android] Text with adjustsFontSizeToFit changes the text layout infinitely  facebook/react-native#33129 by reverting commit facebook/react-native@5902152. PR Fixed dynamic behavior of <Text adjustsFontSizeToFit={true}> on Android facebook/react-native#31538.

[kelset]

(note: if we do 0.67.3 we need to mirror the cherry picks in 0.68 branch to ensure sync)

[joe-sam]

It would be even better if this regression prevention can be scripted.
However I think that major merge conflicts could possibly emerge on an auto cherry pick for the future version compatibility especially if there are drastic version changes and it could prove nearly impossible to do that sort of rebase.
Still it may be worth a shot.

[astragofore]

My team (and judging from many other reactions (here) many would appreciate this released: facebook/react-native#31865
In order to make tests in many applications better functional. In short: resource-id is not available for TextInputs

[ShikaSD]

I think it is already in 0.67, looking at the commit :)

[kelset]

exactly - in the commit (facebook/react-native@efb359f) you can see that it's been part of every RN version >= 0.66:

unless it was reverted at some point - but as far as I can see in main the changes are still present so it doesn't look like it was ever reverted (example: https://github.com/facebook/react-native/blob/main/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java#L131)

[astragofore]

excellent, thank you both!