Skip to content

Commit df54d5e

Browse files
committed
[1.x] Run tests on PHP 8.4 and update test environment
Builds on #218
1 parent eb8ae00 commit df54d5e

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,11 @@ on:
77
jobs:
88
PHPUnit:
99
name: PHPUnit (PHP ${{ matrix.php }})
10-
runs-on: ubuntu-22.04
10+
runs-on: ubuntu-24.04
1111
strategy:
1212
matrix:
1313
php:
14+
- 8.4
1415
- 8.3
1516
- 8.2
1617
- 8.1
@@ -39,13 +40,13 @@ jobs:
3940

4041
PHPUnit-macOS:
4142
name: PHPUnit (macOS)
42-
runs-on: macos-12
43+
runs-on: macos-14
4344
continue-on-error: true
4445
steps:
4546
- uses: actions/checkout@v4
4647
- uses: shivammathur/setup-php@v2
4748
with:
48-
php-version: 8.2
49+
php-version: 8.4
4950
coverage: xdebug
5051
ini-file: development
5152
- run: composer install

tests/Query/TcpTransportExecutorTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ public function testQueryStaysPendingWhenClientCanNotSendExcessiveMessageInOneCh
336336
$query = new Query('google' . str_repeat('.com', 100), Message::TYPE_A, Message::CLASS_IN);
337337

338338
// send a bunch of queries and keep reference to last promise
339-
for ($i = 0; $i < 2000; ++$i) {
339+
for ($i = 0; $i < 20000; ++$i) {
340340
$promise = $executor->query($query);
341341
}
342342

@@ -371,7 +371,7 @@ public function testQueryRejectsWhenClientKeepsSendingWhenServerClosesSocketWith
371371

372372
// send a bunch of queries and keep reference to last promise
373373
$exception = null;
374-
for ($i = 0; $i < 2000; ++$i) {
374+
for ($i = 0; $i < 20000; ++$i) {
375375
$promise = $executor->query($query);
376376
$promise->then(null, function (\Exception $reason) use (&$exception) {
377377
$exception = $reason;

0 commit comments

Comments
 (0)