Skip to content

Conversation

@alexanderjarvis
Copy link

Summary

#94

Test Plan

npm i -g @react-native-community/cli
react-native init test --template react-native-template-typescript
cd test
yarn tsc

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

Copy link
Member

@MateusAndrade MateusAndrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radko93 i tested this, and removing @types/react doesn't affect the types on the project after running a yarn tsc or event using the react types as described at #94.

Do you think its ok apply this?

@radko93
Copy link
Collaborator

radko93 commented Oct 25, 2019

If you can use react types then it's fine. Something has changed recently probably.

@radko93 radko93 merged commit b228bb4 into react-native-community:master Oct 25, 2019
@alexanderjarvis alexanderjarvis deleted the fix/react-type-errors branch October 25, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants