In partial_insertion_sort, moved the SHORTEST_SHIFTING check outside of loop #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f loop While the compiler probably optimizes this, it was confusing to read.
cuviper
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Note that this code was originally an adaptation of the standard library's sort, although that's since been replaced by rust-lang/rust#124032.
|
|
||
| // Are we done? | ||
| if i == len { | ||
| return true; |
There was a problem hiding this comment.
If the SHORTEST_SHIFTING condition is moved up, it changes this case that would have returned true. I haven't fully analyzed that effect, but it's not just about "readability" at that point.
There was a problem hiding this comment.
You are absolutely right. The behaviour on short sorted slices changes, my bad.
There was a problem hiding this comment.
OK, then I'll close this - thanks anyway!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check does not depend on the loop and can be performed at the start.
While the compiler probably optimizes this, it was confusing to read.