feat: Bulk Import Tools modal wiring IBM#737 (IBM#739)

* feat: Bulk Import Tools modal wiring and backend implementation

- Add modal UI in admin.html with bulk import button and dialog
- Implement modal open/close/ESC functionality in admin.js
- Add POST /admin/tools/import endpoint with rate limiting
- Support both JSON textarea and file upload inputs
- Validate JSON structure and enforce 200 tool limit
- Return detailed success/failure information per tool
- Include loading states and comprehensive error handling

Refs IBM#737

Signed-off-by: Mihai Criveti <[email protected]>

* fix: Remove duplicate admin_import_tools function and fix HTML formatting

- Remove duplicate admin_import_tools function definition
- Fix HTML placeholder attribute to use double quotes
- Add missing closing div tag
- Fix flake8 blank line issues

Signed-off-by: Mihai Criveti <[email protected]>

* feat: Complete bulk import backend with file upload support and enhanced docs

- Add file upload support to admin_import_tools endpoint
- Fix response format to match frontend expectations
- Add UI usage documentation with modal instructions
- Update API docs to show all three input methods
- Enhance bulk import guide with UI and API examples

Backend improvements:
- Support tools_file form field for JSON file uploads
- Proper file content parsing with error handling
- Response includes imported/failed counts and details
- Frontend-compatible response format for UI display

Signed-off-by: Mihai Criveti <[email protected]>

* Bulk import

Signed-off-by: Mihai Criveti <[email protected]>

* fix: Remove conflicting inline script and fix bulk import functionality

- Remove conflicting inline JavaScript that was preventing form submission
- Fix indentation in setupBulkImportModal function
- Ensure bulk import modal uses proper admin.js implementation
- Restore proper form submission handling for bulk import

This fixes the issue where bulk import appeared to do nothing.

Signed-off-by: Mihai Criveti <[email protected]>

* fix: Integrate bulk import setup with main initialization

- Add setupBulkImportModal() to main initialization sequence
- Remove duplicate DOMContentLoaded listener
- Ensure bulk import doesn't interfere with other tab functionality

Signed-off-by: Mihai Criveti <[email protected]>

* fix: JavaScript formatting issues in bulk import modal

- Fix multiline querySelector formatting
- Fix multiline Error constructor formatting
- Ensure prettier compliance for web linting

Signed-off-by: Mihai Criveti <[email protected]>

* debug: Temporarily disable bulk import setup to test tabs

Signed-off-by: Mihai Criveti <[email protected]>

* fix: Remove duplicate setupFormValidation call and delay bulk import setup

- Remove duplicate setupFormValidation() call that could cause conflicts
- Use setTimeout to delay bulk import modal setup after other initialization
- Add better null safety to form element queries
- This should fix tab switching issues

Signed-off-by: Mihai Criveti <[email protected]>

* fix: Restore proper initialization sequence for tab functionality

- Remove setTimeout delay for bulk import setup
- Keep bulk import setup in main initialization but with error handling
- Ensure tab navigation isn't affected by bulk import modal setup

Signed-off-by: Mihai Criveti <[email protected]>

* fix: Correct HTML structure and restore tab navigation

- Move bulk import modal to correct location after tools panel
- Remove extra closing div that was breaking HTML structure
- Ensure proper page-level modal placement
- Restore tab navigation functionality for all tabs

This fixes the broken Global Resources, Prompts, Gateways, Roots, and Metrics tabs.

Signed-off-by: Mihai Criveti <[email protected]>

* feat: Add configurable bulk import settings

Configuration additions:
- MCPGATEWAY_BULK_IMPORT_MAX_TOOLS (default: 200)
- MCPGATEWAY_BULK_IMPORT_RATE_LIMIT (default: 10)

Implementation:
- config.py: Add new settings with defaults
- admin.py: Use configurable rate limit and batch size
- .env.example: Document all bulk import environment variables
- admin.html: Use dynamic max tools value in UI text
- CLAUDE.md: Document configuration options for developers
- docs: Update bulk import guide with configuration details

This makes bulk import fully configurable for different deployment scenarios.

Signed-off-by: Mihai Criveti <[email protected]>

* Update docs

Signed-off-by: Mihai Criveti <[email protected]>

---------

Signed-off-by: Mihai Criveti <[email protected]>
Co-authored-by: Mihai Criveti <[email protected]>

Author: 2 people

.env.example

@@ -131,6 +131,12 @@ MCPGATEWAY_ADMIN_API_ENABLED=true
 # Enable bulk import endpoint for tools (true/false)
 MCPGATEWAY_BULK_IMPORT_ENABLED=true
 
+# Maximum number of tools allowed per bulk import request
+MCPGATEWAY_BULK_IMPORT_MAX_TOOLS=200
+
+# Rate limiting for bulk import endpoint (requests per minute)
+MCPGATEWAY_BULK_IMPORT_RATE_LIMIT=10
+
 #####################################
 # Header Passthrough Configuration
 #####################################

CLAUDE.md

@@ -137,6 +137,11 @@ AUTH_REQUIRED=true
 MCPGATEWAY_UI_ENABLED=true
 MCPGATEWAY_ADMIN_API_ENABLED=true
 
+# Bulk Import (Admin UI feature)
+MCPGATEWAY_BULK_IMPORT_ENABLED=true      # Enable/disable bulk import endpoint
+MCPGATEWAY_BULK_IMPORT_MAX_TOOLS=200     # Maximum tools per import batch
+MCPGATEWAY_BULK_IMPORT_RATE_LIMIT=10     # Requests per minute limit
+
 # Federation
 MCPGATEWAY_ENABLE_MDNS_DISCOVERY=true
 MCPGATEWAY_ENABLE_FEDERATION=true

docs/docs/manage/bulk-import.md

@@ -2,34 +2,89 @@
 
 The MCP Gateway provides a bulk import endpoint for efficiently loading multiple tools in a single request, perfect for migrations, environment setup, and team onboarding.
 
-!!! info "Feature Flag Required"
-    This feature is controlled by the `MCPGATEWAY_BULK_IMPORT_ENABLED` environment variable.
-    Default: `true` (enabled). Set to `false` to disable this endpoint.
+!!! info "Configuration Options"
+    This feature is controlled by several environment variables:
+
+    - `MCPGATEWAY_BULK_IMPORT_ENABLED=true` - Enable/disable the endpoint (default: true)
+    - `MCPGATEWAY_BULK_IMPORT_MAX_TOOLS=200` - Maximum tools per batch (default: 200)
+    - `MCPGATEWAY_BULK_IMPORT_RATE_LIMIT=10` - Requests per minute limit (default: 10)
 
 ---
 
 ## 🚀 Overview
 
-The `/admin/tools/import` endpoint allows you to register multiple tools at once, providing:
+The bulk import feature allows you to register multiple tools at once through both the Admin UI and API, providing:
 
 - **Per-item validation** - One invalid tool won't fail the entire batch
 - **Detailed reporting** - Know exactly which tools succeeded or failed
 - **Rate limiting** - Protected against abuse (10 requests/minute)
 - **Batch size limits** - Maximum 200 tools per request
-- **Multiple input formats** - JSON payload or form data
+- **Multiple input formats** - JSON payload, form data, or file upload
+- **User-friendly UI** - Modal dialog with drag-and-drop file support
+
+---
+
+## 🎨 Admin UI Usage
+
+### Accessing the Bulk Import Modal
+
+1. **Navigate to Admin UI** - Open your gateway's admin interface at `http://localhost:4444/admin`
+2. **Go to Tools Tab** - Click on the "Tools" tab in the main navigation
+3. **Open Bulk Import** - Click the "+ Bulk Import Tools" button next to "Add New Tool"
+
+### Using the Modal
+
+The bulk import modal provides two ways to input tool data:
+
+#### Option 1: JSON Textarea
+1. **Paste JSON directly** into the text area
+2. **Validate format** - The modal will check JSON syntax before submission
+3. **Click Import Tools** to process
+
+#### Option 2: File Upload
+1. **Prepare a JSON file** with your tools array
+2. **Click "Choose File"** and select your `.json` file
+3. **Click Import Tools** to process
+
+### UI Features
+
+- **Real-time validation** - JSON syntax checking before submission
+- **Loading indicators** - Progress spinner during import
+- **Detailed results** - Success/failure counts with error details
+- **Auto-refresh** - Page reloads automatically after successful import
+- **Modal controls** - Close with button, backdrop click, or ESC key
 
 ---
 
 ## 📡 API Endpoint
 
-### Request
+### Request Methods
 
+#### Method 1: JSON Body
 ```http
 POST /admin/tools/import
 Authorization: Bearer <jwt_token>
 Content-Type: application/json
 ```
 
+#### Method 2: Form Data (JSON String)
+```http
+POST /admin/tools/import
+Authorization: Bearer <jwt_token>
+Content-Type: multipart/form-data
+
+Form field: tools_json=<json_string>
+```
+
+#### Method 3: File Upload
+```http
+POST /admin/tools/import
+Authorization: Bearer <jwt_token>
+Content-Type: multipart/form-data
+
+Form field: tools_file=<uploaded_json_file>
+```
+
 ### Payload Structure
 
 ```json

mcpgateway/admin.py

@@ -1569,6 +1569,7 @@ async def admin_ui(
             "root_path": root_path,
             "max_name_length": max_name_length,
             "gateway_tool_name_separator": settings.gateway_tool_name_separator,
+            "bulk_import_max_tools": settings.mcpgateway_bulk_import_max_tools,
         },
     )
 
@@ -4386,7 +4387,7 @@ async def admin_list_tags(
 
 @admin_router.post("/tools/import/")
 @admin_router.post("/tools/import")
-@rate_limit(requests_per_minute=10)
+@rate_limit(requests_per_minute=settings.mcpgateway_bulk_import_rate_limit)
 async def admin_import_tools(
     request: Request,
     db: Session = Depends(get_db),
@@ -4429,19 +4430,33 @@ async def admin_import_tools(
             except Exception as ex:
                 LOGGER.exception("Invalid form body")
                 return JSONResponse({"success": False, "message": f"Invalid form data: {ex}"}, status_code=422)
-            raw = form.get("tools_json") or form.get("json") or form.get("payload")
-            if not raw:
-                return JSONResponse({"success": False, "message": "Missing tools_json/json/payload form field."}, status_code=422)
-            try:
-                payload = json.loads(raw)
-            except Exception as ex:
-                LOGGER.exception("Invalid JSON in form field")
-                return JSONResponse({"success": False, "message": f"Invalid JSON: {ex}"}, status_code=422)
+            # Check for file upload first
+            if "tools_file" in form:
+                file = form["tools_file"]
+                if hasattr(file, "file"):
+                    content = await file.read()
+                    try:
+                        payload = json.loads(content.decode("utf-8"))
+                    except (json.JSONDecodeError, UnicodeDecodeError) as ex:
+                        LOGGER.exception("Invalid JSON file")
+                        return JSONResponse({"success": False, "message": f"Invalid JSON file: {ex}"}, status_code=422)
+                else:
+                    return JSONResponse({"success": False, "message": "Invalid file upload"}, status_code=422)
+            else:
+                # Check for JSON in form fields
+                raw = form.get("tools") or form.get("tools_json") or form.get("json") or form.get("payload")
+                if not raw:
+                    return JSONResponse({"success": False, "message": "Missing tools/tools_json/json/payload form field."}, status_code=422)
+                try:
+                    payload = json.loads(raw)
+                except Exception as ex:
+                    LOGGER.exception("Invalid JSON in form field")
+                    return JSONResponse({"success": False, "message": f"Invalid JSON: {ex}"}, status_code=422)
 
         if not isinstance(payload, list):
             return JSONResponse({"success": False, "message": "Payload must be a JSON array of tools."}, status_code=422)
 
-        max_batch = 200
+        max_batch = settings.mcpgateway_bulk_import_max_tools
         if len(payload) > max_batch:
             return JSONResponse({"success": False, "message": f"Too many tools ({len(payload)}). Max {max_batch}."}, status_code=413)
 
@@ -4474,15 +4489,33 @@ async def admin_import_tools(
                 LOGGER.exception("Unexpected error importing tool %r at index %d", name, i)
                 errors.append({"index": i, "name": name, "error": {"message": str(ex)}})
 
-        return JSONResponse(
-            {
-                "success": len(errors) == 0,
-                "created_count": len(created),
-                "failed_count": len(errors),
-                "created": created,
-                "errors": errors,
+        # Format response to match both frontend and test expectations
+        response_data = {
+            "success": len(errors) == 0,
+            # New format for frontend
+            "imported": len(created),
+            "failed": len(errors),
+            "total": len(payload),
+            # Original format for tests
+            "created_count": len(created),
+            "failed_count": len(errors),
+            "created": created,
+            "errors": errors,
+            # Detailed format for frontend
+            "details": {
+                "success": [item["name"] for item in created if item.get("name")],
+                "failed": [{"name": item["name"], "error": item["error"].get("message", str(item["error"]))} for item in errors],
             },
-            status_code=200,
+        }
+
+        if len(errors) == 0:
+            response_data["message"] = f"Successfully imported all {len(created)} tools"
+        else:
+            response_data["message"] = f"Imported {len(created)} of {len(payload)} tools. {len(errors)} failed."
+
+        return JSONResponse(
+            response_data,
+            status_code=200,  # Always return 200, success field indicates if all succeeded
         )
 
     except HTTPException:

mcpgateway/config.py

@@ -150,6 +150,8 @@ class Settings(BaseSettings):
     mcpgateway_ui_enabled: bool = False
     mcpgateway_admin_api_enabled: bool = False
     mcpgateway_bulk_import_enabled: bool = True
+    mcpgateway_bulk_import_max_tools: int = 200
+    mcpgateway_bulk_import_rate_limit: int = 10
 
     # Security
     skip_ssl_verify: bool = False