Revert "Merge pull request #733 from Shopify/default-to-using-spring-with-rails"

This reverts commit 4126e5e, reversing
changes made to 046d50a.

Reason: This was breaking regular `bin/rails test some_file.rb` usage
because the the first arg was being removed from the command line.

Author: rafaelfranca

lib/spring/client/rails.rb

@@ -1,12 +1,14 @@
 module Spring
   module Client
     class Rails < Command
-      SPECIAL_COMMANDS = %w(test)
-      EXCLUDED_COMMANDS = %w(server)
+      COMMANDS = %w(console runner generate destroy test)
 
       ALIASES = {
-        "t" => "test",
-        "s" => "server"
+        "c" => "console",
+        "r" => "runner",
+        "g" => "generate",
+        "d" => "destroy",
+        "t" => "test"
       }
 
       def self.description
@@ -16,15 +18,15 @@ def self.description
       def call
         command_name = ALIASES[args[1]] || args[1]
 
-        if SPECIAL_COMMANDS.include?(command_name)
-          Run.call(["rails_#{command_name}", *args.drop(1)])
-        elsif EXCLUDED_COMMANDS.include?(command_name)
+        if COMMANDS.include?(command_name)
+          Run.call(["rails_#{command_name}", *args.drop(2)])
+        elsif command_name&.start_with?("db:") && !command_name.start_with?("db:system")
+          Run.call(["rake", *args.drop(1)])
+        else
           require "spring/configuration"
           ARGV.shift
           load Dir.glob(Spring.application_root_path.join("{bin,script}/rails")).first
           exit
-        else
-          Run.call(["rails", *args.drop(1)])
         end
       end
     end

lib/spring/commands/rails.rb

@@ -2,35 +2,111 @@ module Spring
   module Commands
     class Rails
       def call
+        ARGV.unshift command_name
         load Dir.glob(::Rails.root.join("{bin,script}/rails")).first
       end
 
+      def description
+        nil
+      end
+    end
+
+    class RailsConsole < Rails
       def env(args)
+        return args.first if args.first && !args.first.index("-")
+
         environment = nil
 
         args.each.with_index do |arg, i|
-          if arg =~ /(-e|--environment)=(\w+)/
-            environment = $2
-          elsif i > 0 && %w[-e --environment].include?(args[i - 1])
+          if arg =~ /--environment=(\w+)/
+            environment = $1
+          elsif i > 0 && args[i - 1] == "-e"
             environment = arg
           end
         end
 
         environment
       end
 
-      def description
-        nil
+      def command_name
+        "console"
+      end
+    end
+
+    class RailsGenerate < Rails
+      def command_name
+        "generate"
+      end
+    end
+
+    class RailsDestroy < Rails
+      def command_name
+        "destroy"
+      end
+    end
+
+    class RailsRunner < Rails
+      def call
+        ARGV.replace extract_environment(ARGV).first
+        super
+      end
+
+      def env(args)
+        extract_environment(args).last
+      end
+
+      def command_name
+        "runner"
+      end
+
+      def extract_environment(args)
+        environment = nil
+
+        args = args.select.with_index { |arg, i|
+          case arg
+          when "-e"
+            false
+          when /--environment=(\w+)/
+            environment = $1
+            false
+          else
+            if i > 0 && args[i - 1] == "-e"
+              environment = arg
+              false
+            else
+              true
+            end
+          end
+        }
+
+        [args, environment]
       end
     end
 
     class RailsTest < Rails
       def env(args)
-        super || "test"
+        environment = "test"
+
+        args.each.with_index do |arg, i|
+          if arg =~ /--environment=(\w+)/
+            environment = $1
+          elsif i > 0 && args[i - 1] == "-e"
+            environment = arg
+          end
+        end
+
+        environment
+      end
+
+      def command_name
+        "test"
       end
     end
 
-    Spring.register_command "rails",          Rails.new
+    Spring.register_command "rails_console",  RailsConsole.new
+    Spring.register_command "rails_generate", RailsGenerate.new
+    Spring.register_command "rails_destroy",  RailsDestroy.new
+    Spring.register_command "rails_runner",   RailsRunner.new
     Spring.register_command "rails_test",     RailsTest.new
   end
 end

test/support/acceptance_test.rb

@@ -740,18 +740,6 @@ class MyEngine < Rails::Engine
 
         assert_failure app.spring_test_command, stderr: "omg (RuntimeError)"
       end
-
-      test "speeds up rake tasks with rails commands" do
-        File.write(app.path("lib/tasks/env.rake"), <<-RUBY.strip_heredoc)
-          namespace :foo do
-            task :bar => :environment
-          end
-        RUBY
-
-        assert_speedup do
-          2.times { app.run "bin/rails foo:bar" }
-        end
-      end
     end
   end
 end

test/unit/commands_test.rb

@@ -2,31 +2,51 @@
 require "spring/commands"
 
 class CommandsTest < ActiveSupport::TestCase
-  test 'rails command sets rails environment from -e option' do
-    command = Spring::Commands::Rails.new
+  test 'console command sets rails environment from command-line option' do
+    command = Spring::Commands::RailsConsole.new
+    assert_equal 'test', command.env(['test'])
+  end
+
+  test 'console command sets rails environment from -e option' do
+    command = Spring::Commands::RailsConsole.new
     assert_equal 'test', command.env(['-e', 'test'])
-    assert_equal 'test', command.env(['-e=test'])
   end
 
-  test 'rails command sets rails environment from --environment option' do
-    command = Spring::Commands::Rails.new
-    assert_equal 'test', command.env(['--environment', 'test'])
+  test 'console command sets rails environment from --environment option' do
+    command = Spring::Commands::RailsConsole.new
     assert_equal 'test', command.env(['--environment=test'])
   end
 
-  test 'rails command ignores first argument if it is a flag except -e and --environment' do
-    command = Spring::Commands::Rails.new
+  test 'console command ignores first argument if it is a flag except -e and --environment' do
+    command = Spring::Commands::RailsConsole.new
     assert_nil command.env(['--sandbox'])
   end
 
-  test 'rails command uses last environment option' do
-    command = Spring::Commands::Rails.new
-    assert_equal 'development', command.env(['-e', 'test', '--environment=development'])
+  test 'Runner#env sets rails environment from command-line option' do
+    command = Spring::Commands::RailsRunner.new
+    assert_equal 'test', command.env(['-e', 'test', 'puts 1+1'])
   end
 
-  test 'rails command ignores additional arguments' do
-    command = Spring::Commands::Rails.new
-    assert_equal 'test', command.env(['-e', 'test', 'puts 1+1'])
+  test 'RailsRunner#env sets rails environment from long form of command-line option' do
+    command = Spring::Commands::RailsRunner.new
+    assert_equal 'test', command.env(['--environment=test', 'puts 1+1'])
+  end
+
+  test 'RailsRunner#env ignores insignificant arguments' do
+    command = Spring::Commands::RailsRunner.new
+    assert_nil command.env(['puts 1+1'])
+  end
+
+  test 'RailsRunner#extract_environment removes -e <env>' do
+    command = Spring::Commands::RailsRunner.new
+    args = ['-b', '-a', '-e', 'test', '-r']
+    assert_equal [['-b', '-a', '-r'], 'test'], command.extract_environment(args)
+  end
+
+  test 'RailsRunner#extract_environment removes --environment=<env>' do
+    command = Spring::Commands::RailsRunner.new
+    args = ['-b', '--environment=test', '-a', '-r']
+    assert_equal [['-b', '-a', '-r'], 'test'], command.extract_environment(args)
   end
 
   test "rake command has configurable environments" do
@@ -37,20 +57,18 @@ class CommandsTest < ActiveSupport::TestCase
     assert_nil command.env(["test_foo"])
   end
 
-  test 'RailsTest#env defaults to test rails environment' do
+  test 'RailsTest#command defaults to test rails environment' do
     command = Spring::Commands::RailsTest.new
     assert_equal 'test', command.env([])
   end
 
-  test 'RailsTest#env sets rails environment from --environment option' do
+  test 'RailsTest#command sets rails environment from --environment option' do
     command = Spring::Commands::RailsTest.new
-    assert_equal 'development', command.env(['--environment', 'development'])
-    assert_equal 'development', command.env(['--environment=development'])
+    assert_equal 'foo', command.env(['--environment=foo'])
   end
 
-  test 'RailsTest#env sets rails environment from -e option' do
+  test 'RailsTest#command sets rails environment from -e option' do
     command = Spring::Commands::RailsTest.new
-    assert_equal 'development', command.env(['-e', 'development'])
-    assert_equal 'development', command.env(['-e=development'])
+    assert_equal 'foo', command.env(['-e', 'foo'])
   end
 end