Commit 8e87a52
authored
Remove
This PR removes `Performance/UnfreezeString` cop.
Starting with Ruby 3.3, the aim of this cop to improve performance by replacing `String#dup` with `String#+@` no longer holds meaning.
- rubocop/rubocop-performance#384
- rubocop/rubocop-performance#418
Currently, Rails 8.0 (rc2) supports Ruby 3.2 and above, but support for Ruby 3.2 will likely be dropped in a future version of Rails.
When that time comes, any use of `String#+@` instead of `String#dup` at the application layer will be unnecessary.
Since this is enforced for performance rather than style, I think it makes sense to disable this cop.
This is a suggestion to disable a cop that will eventually become irrelevant, from the perspective of maintaining RuboCop Performance.
I understand that rubocop-rails-omakase does not expect configuration changes, so please feel free to close this if it doesn’t fit.Performance/UnfreezeString cop (#22)1 parent 63a7608 commit 8e87a52
1 file changed
+0
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | 163 | | |
167 | 164 | | |
168 | 165 | | |
| |||
0 commit comments