Replies: 17 comments 6 replies
-
|
Cross reference: r-universe-org/help#370 |
Beta Was this translation helpful? Give feedback.
-
|
Thank you @jeroen, this is excellent! I can get started on using this API in R-multiverse after I return from next week's vacation. Is it true that As far as the list of checks that would make sense for R-multiverse, what about these?
R-devel seems important so the community is not blindsided by every new version of R, but do we need it for all platforms? |
Beta Was this translation helpful? Give feedback.
-
|
The windows and macos run CMD check. For wasm we only test if we can build. The status is the status of the primary job, which does the checkout, builds the source package, documentation, metadata, etc. |
Beta Was this translation helpful? Give feedback.
-
|
Then I guess it would be pragmatic for users just to use |
Beta Was this translation helpful? Give feedback.
-
|
We have r-devel for Linux and Windows, so I can add those as well. UBSAN and Valgrind are complicated in many ways. Also the results are not easy to interpret. There is often no clear pass or fail for valgrind, it just emits a lot of diagnostic info that you have to comb through to look for anything concerning. We can cross that bridge when we get there, hopefully we can go ahead and develop r-multiverse based on the checks that are available? Than we can always plug in another check when later on. |
Beta Was this translation helpful? Give feedback.
-
What about borrowing those workflows from |
Beta Was this translation helpful? Give feedback.
-
|
Should also test which packages actually pass. IIRC Cairo blows up Valgrind but CRAN still keeps it because it has too many revdeps to fail. |
Beta Was this translation helpful? Give feedback.
-
|
The results are also not consistent on r-hub. Valgrind is mainly a debugging tool. The valgrind warnings that cran (used to) show are also often false positives, even CRAN admins among themselves can often not reproduce the results. The number of real bugs that you find with this is close to zero. I don't think we should put a ton of energy in this, the usefulness of this is very small. |
Beta Was this translation helpful? Give feedback.
-
|
Same with sanitizers? |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, it is similar. Sanitizers make the process very slow, so most check errors that you encounter with this are merely artifacts of the slowness, e.g. you are hitting timeouts where normally never would. Perhaps we can revisit at some point if better tooling becomes available, but generally speaking sanitizers are very expensive, have a high false positive rate, and the added value of this in terms if quality control is very minimal. Again, it can be useful for debugging your local code, but as a CI tool not so much. |
Beta Was this translation helpful? Give feedback.
-
|
UBSAN and Valgrind both fall under 'future work' so we can indeed cross that bridge when we get there. Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
I agree, the absence of UBSAN/Valgrind does not block anything on the R-multiverse side. |
Beta Was this translation helpful? Give feedback.
-
|
@jeroen, is it possible to view the response in ndjson so we can use |
Beta Was this translation helpful? Give feedback.
-
|
Alternatively, do you have a recommendation for handling paginated output from https://multiverse.r-multiverse.org/api/packages? |
Beta Was this translation helpful? Give feedback.
-
|
Also, under what conditions would e.g. |
Beta Was this translation helpful? Give feedback.
-
Yes you can add |
Beta Was this translation helpful? Give feedback.
-
|
After learning more about WASM at Posit Conf, I think we should not require Production to be WASM-compliant. Only about 60% of packages currently are, and it may take several years to get there for most packages, especially ones that use networking and multithreading. |
Beta Was this translation helpful? Give feedback.
-
|
Agree. |
Beta Was this translation helpful? Give feedback.
-
|
Yes WASM will be "experimental" for the upcoming years. It is also impossible to run CMD check on wasm because it has to be cross compiled, and we cannot run the wasm binaries after we built them, they only run in a browser or nodejs. |
Beta Was this translation helpful? Give feedback.
-
|
Regarding the original thread: from https://github.com/r-universe/r-multiverse/actions/runs/12140711981, it looks like a lot of builds are already covered. I guess the only additional one I might ask for is R-release for Linux. Which versions of R does the API access in |
Beta Was this translation helpful? Give feedback.
-
|
After our discussion today, I'm thinking R-multiverse could directly use the data in @jeroen, would it be possible for R-release on Linux to report R CMD check status? https://community.r-multiverse.org/api/packages?fields=_binaries shows: {
"Package": "prqlr",
"_user": "r-multiverse",
"_type": "src",
"_status": "success",
"_commit": {
"id": "9bcc6ef530582844da1e8c8b5e3faa8477a5ecd2"
},
"_indexed": false,
"_binaries": [
{
"r": "4.5.0",
"os": "linux",
"arch": "x86_64",
"commit": "9bcc6ef530582844da1e8c8b5e3faa8477a5ecd2",
"status": "success",
"check": "OK"
},
{
"r": "4.4.1",
"os": "linux",
"arch": "x86_64",
"commit": "9bcc6ef530582844da1e8c8b5e3faa8477a5ecd2",
"status": "success"
},It would be great to have something like "check: OK" under |
Beta Was this translation helpful? Give feedback.
-
|
Here is a typical example of ASAN in practice (click |
Beta Was this translation helpful? Give feedback.
-
|
R-multiverse uses the |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
As a starting point the standard packages API can be used to get check status for the
r-releasefor the various platforms: https://r-multiverse.r-universe.dev/api/packages?fields=_linuxdevel,_winbinary,_macbinary,_wasmbinary,_status,_buildurlWhere
_status != "success"indicates problems with building vignettes and documentation. The other fields are binary build/checks. They can be "success" or "failure" (package was built, but there was a check error) or "none" (failed to build package for this platform) or "skipped".Also note INLA which is what it looks like when cannot even build the source package.
What is not part of this API is checks for r-oldrel, which we od have for some platforms, although it usually gets dropped in the later stages of the R release cycle when we start testing for the next release of R. FWIW CRAN does not enforce checks for oldrel either.
Beta Was this translation helpful? Give feedback.
All reactions