Skip to content

Commit 5b1a418

Browse files
committed
Pin huggingface_hub<1.0 (#15399)
Trying to fix failing HF CI jobs. Looks like our transformers version requires huggingface_hub<1.0, but we're installing the latest 1.0 version which just released today. Until we bump transformers, I'll just pin our install of huggingface_hub to below 1.0. Note that we don't pin the transformers version the same way for pip install, so this should be a ci only issue (and hence ci only fix). Here's an example job failure: ``` transformers 4.56.1 requires huggingface-hub<1.0,>=0.34.0, but you have huggingface-hub 1.0.0 which is incompatible. ... /exec: line 13: huggingface-cli: command not found ``` (from https://github.com/pytorch/executorch/actions/runs/18851188516/job/53787937311) (cherry picked from commit 57f0dfd)
1 parent a9ef570 commit 5b1a418

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

.github/workflows/pull.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -307,9 +307,12 @@ jobs:
307307
308308
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh --build-tool "cmake"
309309
310-
# install Llava requirements
311-
bash examples/models/llama/install_requirements.sh
312-
bash examples/models/llava/install_requirements.sh
310+
echo "::group::Setup Huggingface"
311+
pip install -U "huggingface_hub[cli]<1.0" accelerate
312+
huggingface-cli login --token $SECRET_EXECUTORCH_HF_TOKEN
313+
OPTIMUM_ET_VERSION=$(cat .ci/docker/ci_commit_pins/optimum-executorch.txt)
314+
pip install git+https://github.com/huggingface/optimum-executorch.git@${OPTIMUM_ET_VERSION}
315+
echo "::endgroup::"
313316
314317
# run python unittest
315318
python -m unittest examples.models.llava.test.test_llava
@@ -625,7 +628,9 @@ jobs:
625628
conda activate "${CONDA_ENV}"
626629
627630
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh --build-tool "cmake"
631+
echo "::endgroup::"
628632
633+
echo "::group::Setup requirements"
629634
# install phi-3-mini requirements
630635
bash examples/models/phi-3-mini/install_requirements.sh
631636

.github/workflows/trunk.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -809,7 +809,7 @@ jobs:
809809
echo "::endgroup::"
810810
811811
echo "::group::Setup Huggingface"
812-
pip install -U "huggingface_hub[cli]" accelerate
812+
pip install -U "huggingface_hub[cli]<1.0" accelerate
813813
huggingface-cli login --token $SECRET_EXECUTORCH_HF_TOKEN
814814
OPTIMUM_ET_VERSION=$(cat .ci/docker/ci_commit_pins/optimum-executorch.txt)
815815
pip install git+https://github.com/huggingface/optimum-executorch.git@${OPTIMUM_ET_VERSION}

0 commit comments

Comments
 (0)