Skip to content

bpo-36517: Raise error on multiple inheritance with NamedTuple #19363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2020
Merged

bpo-36517: Raise error on multiple inheritance with NamedTuple #19363

merged 2 commits into from
Apr 4, 2020

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 4, 2020 •
edited by bedevere-bot
Loading

@gvanrossum gvanrossum changed the title bpo-36517: Raise error on multiple inharitence with NamedTuple. bpo-36517: Raise error on multiple inheritance with NamedTuple Apr 4, 2020
ilevkivskyi
ilevkivskyi approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LG!

@serhiy-storchaka serhiy-storchaka merged commit a94e627 into python:master Apr 4, 2020
@serhiy-storchaka serhiy-storchaka deleted the typing-namedtuple-no-multiple-inheritance branch April 4, 2020 18:31
@tirkarthi tirkarthi mentioned this pull request Oct 11, 2020
Closed
@sebastianw sebastianw mentioned this pull request Nov 13, 2020
Closed
@eggman64 eggman64 mentioned this pull request Feb 3, 2021
Closed
1 task
@glensc glensc mentioned this pull request Jan 15, 2022
Draft
9 tasks
nhuet added a commit to nhuet/scikit-decide that referenced this pull request May 12, 2022
@nhuet
Remove python 3.9 tests as they crash for now
77ba318 
The error traceback:

/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/discrete_optimization/tsp/tsp_model.py:267: in <module>
    class Point2D(Point, NamedTuple):
/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/typing.py:1929: in _namedtuple_mro_entries
    raise TypeError("Multiple inheritance with NamedTuple is not supported")
E   TypeError: Multiple inheritance with NamedTuple is not supported

Coming from python/cpython#19363

Potential solution: replace NamedTuple by Dataclass(frozen=True)
nhuet added a commit to nhuet/scikit-decide that referenced this pull request May 12, 2022
@nhuet
Remove python 3.9 tests as they crash for now
535e9a9 
The error traceback:

/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/discrete_optimization/tsp/tsp_model.py:267: in <module>
    class Point2D(Point, NamedTuple):
/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/typing.py:1929: in _namedtuple_mro_entries
    raise TypeError("Multiple inheritance with NamedTuple is not supported")
E   TypeError: Multiple inheritance with NamedTuple is not supported

Coming from python/cpython#19363

Potential solution: replace NamedTuple by Dataclass(frozen=True)
nhuet added a commit to nhuet/scikit-decide that referenced this pull request May 13, 2022
@nhuet
Remove python 3.9 tests as they crash for now
725d421 
The error traceback:

/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/discrete_optimization/tsp/tsp_model.py:267: in <module>
    class Point2D(Point, NamedTuple):
/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/typing.py:1929: in _namedtuple_mro_entries
    raise TypeError("Multiple inheritance with NamedTuple is not supported")
E   TypeError: Multiple inheritance with NamedTuple is not supported

Coming from python/cpython#19363

Potential solution: replace NamedTuple by Dataclass(frozen=True)
nhuet added a commit to nhuet/discrete-optimization that referenced this pull request Jun 27, 2022
@nhuet
Remove python 3.9 tests as they crash for now
abda509 
The error traceback:

/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/discrete_optimization/tsp/tsp_model.py:267: in <module>
    class Point2D(Point, NamedTuple):
/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/typing.py:1929: in _namedtuple_mro_entries
    raise TypeError("Multiple inheritance with NamedTuple is not supported")
E   TypeError: Multiple inheritance with NamedTuple is not supported

Coming from python/cpython#19363

Potential solution: replace NamedTuple by Dataclass(frozen=True)
nhuet added a commit to nhuet/discrete-optimization that referenced this pull request Jun 27, 2022
@nhuet
Remove python 3.9 tests as they crash for now
6e65ea3 
The error traceback:

/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/discrete_optimization/tsp/tsp_model.py:267: in <module>
    class Point2D(Point, NamedTuple):
/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/typing.py:1929: in _namedtuple_mro_entries
    raise TypeError("Multiple inheritance with NamedTuple is not supported")
E   TypeError: Multiple inheritance with NamedTuple is not supported

Coming from python/cpython#19363

Potential solution: replace NamedTuple by Dataclass(frozen=True)
nhuet added a commit to nhuet/discrete-optimization that referenced this pull request Jun 27, 2022
@nhuet
Remove python 3.9 tests as they crash for now
e9c662a 
The error traceback:

/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/discrete_optimization/tsp/tsp_model.py:267: in <module>
    class Point2D(Point, NamedTuple):
/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/typing.py:1929: in _namedtuple_mro_entries
    raise TypeError("Multiple inheritance with NamedTuple is not supported")
E   TypeError: Multiple inheritance with NamedTuple is not supported

Coming from python/cpython#19363

Potential solution: replace NamedTuple by Dataclass(frozen=True)
nhuet added a commit to nhuet/discrete-optimization that referenced this pull request Jun 27, 2022
@nhuet
Remove python 3.9 tests as they crash for now
b0c131f 
The error traceback:

/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/discrete_optimization/tsp/tsp_model.py:267: in <module>
    class Point2D(Point, NamedTuple):
/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/typing.py:1929: in _namedtuple_mro_entries
    raise TypeError("Multiple inheritance with NamedTuple is not supported")
E   TypeError: Multiple inheritance with NamedTuple is not supported

Coming from python/cpython#19363

Potential solution: replace NamedTuple by Dataclass(frozen=True)
nhuet added a commit to nhuet/discrete-optimization that referenced this pull request Jun 28, 2022
@nhuet
Remove python 3.9 tests as they crash for now
58241ca 
The error traceback:

/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/discrete_optimization/tsp/tsp_model.py:267: in <module>
    class Point2D(Point, NamedTuple):
/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/typing.py:1929: in _namedtuple_mro_entries
    raise TypeError("Multiple inheritance with NamedTuple is not supported")
E   TypeError: Multiple inheritance with NamedTuple is not supported

Coming from python/cpython#19363

Potential solution: replace NamedTuple by Dataclass(frozen=True)
nhuet added a commit to nhuet/discrete-optimization that referenced this pull request Jun 28, 2022
@nhuet
Remove python 3.9 tests as they crash for now
6b25d86 
The error traceback:

/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/discrete_optimization/tsp/tsp_model.py:267: in <module>
    class Point2D(Point, NamedTuple):
/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/typing.py:1929: in _namedtuple_mro_entries
    raise TypeError("Multiple inheritance with NamedTuple is not supported")
E   TypeError: Multiple inheritance with NamedTuple is not supported

Coming from python/cpython#19363

Potential solution: replace NamedTuple by Dataclass(frozen=True)
nhuet added a commit to nhuet/discrete-optimization that referenced this pull request Jun 28, 2022
@nhuet
Remove python 3.9 tests as they crash for now
a642d78 
The error traceback:

/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/site-packages/discrete_optimization/tsp/tsp_model.py:267: in <module>
    class Point2D(Point, NamedTuple):
/opt/hostedtoolcache/Python/3.9.12/x64/lib/python3.9/typing.py:1929: in _namedtuple_mro_entries
    raise TypeError("Multiple inheritance with NamedTuple is not supported")
E   TypeError: Multiple inheritance with NamedTuple is not supported

Coming from python/cpython#19363

Potential solution: replace NamedTuple by Dataclass(frozen=True)
@kinow kinow mentioned this pull request Jun 29, 2022
Closed
tonio-m added a commit to tonio-m/fsql that referenced this pull request Aug 10, 2022
@tonio-m
remove double inheritance with NamedTuple
d25a3ad 
remove double inheritance with NamedTuple to avoid TypeError, as per python 3.9: 
python/cpython#19363
@tonio-m tonio-m mentioned this pull request Aug 10, 2022
Closed
@jakubpernis jakubpernis mentioned this pull request Sep 15, 2022
Closed
@rectalogic rectalogic mannequin mentioned this pull request Apr 10, 2023
Closed
gmgunter added a commit to isce-framework/isce3 that referenced this pull request May 1, 2025
@gmgunter
Un-parameterize Rectangle
8025d27 
This doesn't work in Python >=3.9 until Python 3.11. Multiple
inheritance with `NamedTuple` has limited support.

See:

* python/cpython#19363
* python/cpython#88089
* python/cpython#92027
gmgunter added a commit to isce-framework/isce3 that referenced this pull request Aug 18, 2025
@gmgunter
Add a function to compute a radar grid that spans an input geocoded g…
9c58871 
…rid (MCR #90132) (#99)

* Add bindings for `GLOBAL_MIN_HEIGHT` and `GLOBAL_MAX_HEIGHT`

Expose the C++ constants `isce3::core::GLOBAL_MIN_HEIGHT` and
`isce3::core::GLOBAL_MAX_HEIGHT` to Python.

* Add function to compute radar grid spanning a geo grid

* Simplify radar grid construction by ignoring grid coordinate conventions

See the discussion on this comment:
https://github-fn.jpl.nasa.gov/isce-3/isce/pull/2097#discussion_r26503

* Un-parameterize `Rectangle`

This doesn't work in Python >=3.9 until Python 3.11. Multiple
inheritance with `NamedTuple` has limited support.

See:

* python/cpython#19363
* python/cpython#88089
* python/cpython#92027

* Add `look_side` to be a string

* Simplify error messages

* Rename inner function to avoid name ambiguity

* Fix test regexes

* Add test cases for antimeridian and pole crossing

* Explain dummy parameter values used in test

* Test `get_bounding_rectangle()` with +/-inf

* Rename inner function to avoid name ambiguity

* Update docstrings

* Swap inner/outer loop order

* Specify default geo2rdr tolerance

* Clarify isce3 projection description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @ilevkivskyi @the-knights-who-say-ni @bedevere-bot