Fix out of bounds access in unsafeCodePointAt0Fallback
#112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`unsafeCodePointAt0Fallback` crashed when passed a string of length 1 due to always accessing index 1.
michaelficarra
approved these changes
Nov 10, 2018
Contributor
michaelficarra
left a comment
michaelficarra
left a comment
There was a problem hiding this comment.
Very nice. Great catch, and thanks for the testing idea.
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The precondition for
unsafeCodePointAt0is that the string length in code units is at least 1. But the fallback version only worked for length > 2, because it always accessed index 1.This was not caught by the test suite, because fallbacks are not used in node.js. I added a second test run to the test script that forces the use of fallbacks.