[IAC-1735] - update spec tests #1289
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianiurca
force-pushed
the
repair-spec-tests
branch
from
2e458db to
91465a9
Compare
adrianiurca
force-pushed
the
repair-spec-tests
branch
from
35501c4 to
6a68ec9
Compare
smortex
reviewed
Aug 11, 2021
Collaborator
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
LGTM, but I am confused about this new function 🤔
spec/spec_helper_local.rb
Outdated
Comment on lines
47
to
50
| def postgresql_version | ||
| '9.6' | ||
| end | ||
|
|
Collaborator
There was a problem hiding this comment.
This function does not seem to be used in the rest of the changes of this PR. Was it added by mistake?
ekohl
approved these changes
Aug 15, 2021
Collaborator
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I removed the additional method. Will squash on merge.
Collaborator
|
Ah, I now see this was added because it's actually used in |
Collaborator
|
I opened #1291 which takes most of this commit, but fixes the broken unit test separately with let blocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests related to classes or defines which are using
ensure_packagesfunction fromstdlibneeds to be updated accordingly to this PR puppetlabs/puppetlabs-stdlib#1196