fix: invalid syntax in descriptor.proto #2092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change (protobufjs#2075) edited descriptor.proto to include a `reserved` statement that combines a field number and field name in the same line. This is specifically called out in the proto language guide as invalid. https://protobuf.dev/programming-guides/editions/#reserved > Note that you can’t mix field names and numeric values in the same > `reserved` statement. Protobuf.js itself seems to handle this syntax just fine, but other tools like protoc will choke on it.
waclock
approved these changes
Aug 14, 2025
mkruskal-google
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change (#2075) edited descriptor.proto to include a
reservedstatement that combines a field number and field name in the same line. This is specifically called out in the proto language guide as invalid.https://protobuf.dev/programming-guides/editions/#reserved
Protobuf.js itself seems to handle this syntax just fine, but other tools like protoc will choke on it.