fix: descriptor extensions handling post-editions #2075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkruskal-google
force-pushed
the
descriptor-ext
branch
from
da4ec66 to
f39bb00
Compare
sofisl
approved these changes
May 28, 2025
josephharrington
added a commit
to josephharrington/protobuf.js
that referenced
this pull request
Aug 14, 2025
A recent change (protobufjs#2075) edited descriptor.proto to include a `reserved` statement that combines a field number and field name in the same line. This is specifically called out in the proto language guide as invalid. https://protobuf.dev/programming-guides/editions/#reserved > Note that you can’t mix field names and numeric values in the same > `reserved` statement. Protobuf.js itself seems to handle this syntax just fine, but other tools like protoc will choke on it.
mkruskal-google
pushed a commit
that referenced
this pull request
Aug 15, 2025
A recent change (#2075) edited descriptor.proto to include a `reserved` statement that combines a field number and field name in the same line. This is specifically called out in the proto language guide as invalid. https://protobuf.dev/programming-guides/editions/#reserved > Note that you can’t mix field names and numeric values in the same > `reserved` statement. Protobuf.js itself seems to handle this syntax just fine, but other tools like protoc will choke on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension had virtually no test coverage and was already fairly buggy in proto2/proto3. The addition of editions support broke it completely though, notably #2068 which added some caching that doesn't work in the case of root-less types.
This PR adds some basic test coverage, and cleans up the code to work more smoothly under editions. It is still not safe to use it in the following cases, where it will produce bad results:
Fixes #2072