Skip to content

Create GitHub action to automate mcad release #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2023
Merged

Create GitHub action to automate mcad release #427

merged 2 commits into from
Jul 5, 2023

Conversation

@Srihari1192
Copy link
Contributor

@Srihari1192 Srihari1192 commented Jun 22, 2023

Fixes #408

sutaakar
sutaakar reviewed Jun 22, 2023
View reviewed changes
@Srihari1192 Srihari1192 force-pushed the automate-release-408 branch from b51a06f to 6f4fade Compare June 23, 2023 09:32
@Srihari1192 Srihari1192 marked this pull request as ready for review June 23, 2023 09:36
@Srihari1192 Srihari1192 requested review from sutaakar and z103cb June 23, 2023 09:36
@sutaakar
Copy link
Contributor

sutaakar commented Jun 23, 2023

Changes look ok to me, though I am not so familiar with MCAD Makefile implementation to review Makefile changes.
@Srihari1192 I see that Travis fail on missing CONTROLLER_VERSION. Can you adjust the Travis config to not require that file?

@Srihari1192
Copy link
Contributor Author

Srihari1192 commented Jun 23, 2023 •
edited
Loading

Changes look ok to me, though I am not so familiar with MCAD Makefile implementation to review Makefile changes. @Srihari1192 I see that Travis fail on missing CONTROLLER_VERSION. Can you adjust the Travis config to not require that file?

Sure.. Seems i missed to update CONTROLLER_VERSION file deletion changes to incorporate in Dockerfile and deployment/Makefile.. I will update it

@Srihari1192 Srihari1192 force-pushed the automate-release-408 branch from 6f4fade to 1d7cbee Compare June 23, 2023 13:15
@anishasthana anishasthana requested a review from asm582 June 24, 2023 16:29
sutaakar
sutaakar reviewed Jun 26, 2023
View reviewed changes
z103cb
z103cb suggested changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation updates, indentation.

sutaakar
sutaakar reviewed Jun 27, 2023
View reviewed changes
@Srihari1192 Srihari1192 requested review from sutaakar and z103cb June 28, 2023 09:41
asm582
asm582 previously approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@asm582 asm582 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, It would be great if we can create branches per release. creating an automated branch could be a follow-up PR but this is needed for sure.

sutaakar
sutaakar reviewed Jun 29, 2023
View reviewed changes
@sutaakar sutaakar self-requested a review June 30, 2023 09:05
sutaakar
sutaakar reviewed Jun 30, 2023
View reviewed changes
sutaakar
sutaakar reviewed Jun 30, 2023
View reviewed changes
sutaakar
sutaakar suggested changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow doesn't work properly based on experiments with my fork.

sutaakar
sutaakar reviewed Jun 30, 2023
View reviewed changes
@Srihari1192
Copy link
Contributor Author

Srihari1192 commented Jul 3, 2023

Workflow doesn't work properly based on experiments with my fork.

I have yet to test this workflow, will update PR with new changes as per review comments and will test it

@Srihari1192 Srihari1192 force-pushed the automate-release-408 branch from 09bdaca to 6fd9de2 Compare July 3, 2023 07:29
KPostOffice
KPostOffice reviewed Jul 3, 2023
View reviewed changes
@Srihari1192 Srihari1192 force-pushed the automate-release-408 branch from 6fd9de2 to 059b5c3 Compare July 4, 2023 05:30
@Srihari1192
Copy link
Contributor Author

Srihari1192 commented Jul 4, 2023

I tested this workflow on https://github.com/Srihari1192/multi-cluster-app-dispatcher/actions/workflows/mcad-release.yml looks good

@sutaakar sutaakar mentioned this pull request Jul 4, 2023
Merged
z103cb
z103cb approved these changes Jul 5, 2023
View reviewed changes
@anishasthana anishasthana merged commit 2b7da3a into project-codeflare:main Jul 5, 2023
@Srihari1192 Srihari1192 deleted the automate-release-408 branch July 6, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

@asm582 asm582 Awaiting requested review from asm582

3 more reviewers

@sutaakar sutaakar sutaakar approved these changes

@anishasthana anishasthana anishasthana approved these changes

@z103cb z103cb z103cb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create GitHub action to automate mcad release

6 participants

@Srihari1192 @sutaakar @asm582 @anishasthana @KPostOffice @z103cb