Skip to content

Commit da08c4a

Browse files
committed
add preemptable candidates
1 parent de677ec commit da08c4a

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

pkg/controller/queuejob/queuejob_controller_ex.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -954,9 +954,7 @@ func (qjm *XController) getAggregatedAvailableResourcesPriority(unallocatedClust
954954
continue
955955
}
956956

957-
preemptableAWs[value.Status.SystemPriority] = append(preemptableAWs[value.Status.SystemPriority], queueJobKey)
958-
preemptableAWsMap[queueJobKey] = value
959-
klog.V(10).Infof("[getAggAvaiResPri] %s: Added %s to candidate preemptable job with priority %f.", time.Now().String(), value.Name, value.Status.SystemPriority)
957+
addPreemptableAWs(preemptableAWs, value, queueJobKey, preemptableAWsMap)
960958
}
961959

962960
err := qjm.qjobResControls[arbv1.ResourceTypePod].UpdateQueueJobStatus(value)
@@ -968,6 +966,8 @@ func (qjm *XController) getAggregatedAvailableResourcesPriority(unallocatedClust
968966
klog.V(10).Infof("[getAggAvaiResPri] total resources consumed by Appwrapper %v when lower priority compared to target are %v", value.Name, totalResource)
969967
preemptable = preemptable.Add(totalResource)
970968
klog.V(6).Infof("[getAggAvaiResPri] %s proirity %v is lower target priority %v reclaiming total preemptable resources %v", value.Name, value.Status.SystemPriority, targetpr, totalResource)
969+
queueJobKey, _ := GetQueueJobKey(value)
970+
addPreemptableAWs(preemptableAWs, value, queueJobKey, preemptableAWsMap)
971971
continue
972972
} else if qjm.isDispatcher {
973973
// Dispatcher job does not currently track pod states. This is
@@ -1016,6 +1016,12 @@ func (qjm *XController) getAggregatedAvailableResourcesPriority(unallocatedClust
10161016
return r, proposedPremptions
10171017
}
10181018

1019+
func addPreemptableAWs(preemptableAWs map[float64][]string, value *arbv1.AppWrapper, queueJobKey string, preemptableAWsMap map[string]*arbv1.AppWrapper) {
1020+
preemptableAWs[value.Status.SystemPriority] = append(preemptableAWs[value.Status.SystemPriority], queueJobKey)
1021+
preemptableAWsMap[queueJobKey] = value
1022+
klog.V(10).Infof("[getAggAvaiResPri] %s: Added %s to candidate preemptable job with priority %f.", time.Now().String(), value.Name, value.Status.SystemPriority)
1023+
}
1024+
10191025
func (qjm *XController) chooseAgent(qj *arbv1.AppWrapper) string {
10201026

10211027
qjAggrResources := qjm.GetAggregatedResources(qj)

0 commit comments

Comments
 (0)