Skip to content

Conversation

@sutaakar
Copy link
Contributor

Issue link

project-codeflare/codeflare-common#18

What changes have been made

Replace own KinD composite action with a reference from CodeFlare common repository.

Verification steps

Run PR checks.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@sutaakar sutaakar requested review from ChristianZaccaria and astefanutti and removed request for KPostOffice and Maxusmusti November 30, 2023 12:10
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I like to see this amount of code reduction and following DRY principle. The same will be applied on the codeflare-sdk repo. Thanks! /lgtm /approve

@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, ChristianZaccaria

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@astefanutti
Copy link
Contributor

Great!

@openshift-merge-bot openshift-merge-bot bot merged commit 148d43f into project-codeflare:main Nov 30, 2023
@sutaakar sutaakar deleted the kind branch November 30, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants