Updated MCAD controller cluster role for ingresses #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedhtchang
reviewed
Oct 19, 2023
Contributor
tedhtchang
left a comment
tedhtchang
left a comment
There was a problem hiding this comment.
I think until this project-codeflare/codeflare-sdk#251 is merged into the next SDK release we will need both route and ingress; otherwise current SDK release cannot create route.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tedhtchang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
closes: #347
What changes have been made
Removed the routes resources in favour of ingress resources.
This will be needed for when project-codeflare/codeflare-sdk/pull/251 is merged as we will be moving towards creating ingresses over routes.
Verification steps
Checks