Adding instascale e2e test

[Fiona-Waters]

Issue link

Closes project-codeflare/instascale#66

What changes have been made

An e2e test has been added to test the entire instascale flow on an OSD Cluster.

Verification steps

• Provision an OSD cluster
• Install the codeflare stack following the Quick Start and ensuring you follow the specific instructions here.
• A NodeFeatureDiscovery CR and ClusterPolicy CR are required also. These can be added using the updated makefile - if installing using make all-in-one these should already be present. NFD and ClusterPolicy.
• Using VS Code provide the cluster ID in a .vscode/settings.json file like this

{
   "go.testEnvVars": {
       "CLUSTERID": "261l6dk6frpvmt49csi90uhc6p7nrq7h",
   },
   "go.testFlags": ["-v", "-count=1"]
}

• In your VS code terminal log in to your cluster.
• Run or Debug the test.

Other Considerations

• Testing on an OSD cluster the test fails as the current instascale functionality creates machine pools but then deletes the underlying machines, leaving behind the machine pools.
• Testing on an OSD cluster on top of this PR the test passes as the updated instascale functionality creates and then deletes the machine pools. Image used: quay.io/rh_ee_fwaters/instascale-controller:test

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[sutaakar]

@astefanutti @dimakis Can you please take a look?

[astefanutti]

Very well done! Just left of couple of comments, otherwise looks very good!

[astefanutti]

Could it be assumed that it's an OSD cluster if an OSD cluster ID has been provided?

[Fiona-Waters]

Yes I think so, I have updated to reflect this.

[Fiona-Waters]

@astefanutti @dimakis Can you please take a look?

Thanks for the review @astefanutti ! I have pushed some changes if you could take another look when you have time please.

[astefanutti]

/lgtm

Great work!

[astefanutti]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [astefanutti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment