Return error message if IngressDomain configuration not set

Author: ChristianZaccaria

main.go

@@ -115,7 +115,7 @@ func main() {
 		},
 		KubeRay: &config.KubeRayConfiguration{
 			RayDashboardOAuthEnabled: pointer.Bool(true),
-			IngressDomain:            "fake.domain",
+			IngressDomain:            "",
 		},
 	}
 

pkg/controllers/support.go

@@ -139,15 +139,17 @@ func isOpenShift(ctx context.Context, clientset *kubernetes.Clientset, cluster *
 }
 
 // getIngressHost generates the cluster URL string based on the cluster type, RayCluster, and ingress domain.
-func (r *RayClusterReconciler) getIngressHost(ctx context.Context, clientset *kubernetes.Clientset, cluster *rayv1.RayCluster, ingressNameFromCluster string) string {
-	ingressDomain := "fake.domain"
+func (r *RayClusterReconciler) getIngressHost(ctx context.Context, clientset *kubernetes.Clientset, cluster *rayv1.RayCluster, ingressNameFromCluster string) (string, error) {
+	ingressDomain := ""
 	if r.Config != nil && r.Config.IngressDomain != "" {
 		ingressDomain = r.Config.IngressDomain
+	} else {
+		return "", fmt.Errorf("Missing IngressDomain configuration in ConfigMap 'codeflare-operator-config'")
 	}
 	if ingressDomain == "kind" {
-		return ingressDomain
+		return ingressDomain, nil
 	}
-	return fmt.Sprintf("%s-%s.%s", ingressNameFromCluster, cluster.Namespace, ingressDomain)
+	return fmt.Sprintf("%s-%s.%s", ingressNameFromCluster, cluster.Namespace, ingressDomain), nil
 }
 
 func (r *RayClusterReconciler) isRayDashboardOAuthEnabled() bool {