Process error and fail reconciliation

Author: ChristianZaccaria

pkg/config/config.go

@@ -34,7 +34,7 @@ type CodeFlareOperatorConfiguration struct {
 type KubeRayConfiguration struct {
 	RayDashboardOAuthEnabled *bool `json:"rayDashboardOAuthEnabled,omitempty"`
 
-	IngressDomain string `json:"ingressDomain,omitempty"`
+	IngressDomain string `json:"ingressDomain"`
 }
 
 type ControllerManager struct {

pkg/controllers/raycluster_controller.go

@@ -187,16 +187,24 @@ func (r *RayClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request)
 		logger.Info("We detected being on Vanilla Kubernetes!")
 		logger.Info("Creating Dashboard Ingress")
 		dashboardName := dashboardNameFromCluster(&cluster)
-		dashboardIngressHost, _ := r.getIngressHost(ctx, r.kubeClient, &cluster, dashboardName)
-		_, err := r.kubeClient.NetworkingV1().Ingresses(cluster.Namespace).Apply(ctx, desiredClusterIngress(&cluster, dashboardIngressHost), metav1.ApplyOptions{FieldManager: controllerName, Force: true})
+		dashboardIngressHost, err := r.getIngressHost(ctx, r.kubeClient, &cluster, dashboardName)
+		if err != nil{
+			logger.Error(err, "missing IngressDomain configuration in ConfigMap 'codeflare-operator-config'")
+			return ctrl.Result{RequeueAfter: requeueTime}, err
+		}
+		_, err = r.kubeClient.NetworkingV1().Ingresses(cluster.Namespace).Apply(ctx, desiredClusterIngress(&cluster, dashboardIngressHost), metav1.ApplyOptions{FieldManager: controllerName, Force: true})
 		if err != nil {
 			// This log is info level since errors are not fatal and are expected
 			logger.Info("WARN: Failed to update Dashboard Ingress", "error", err.Error(), logRequeueing, true)
 			return ctrl.Result{RequeueAfter: requeueTime}, err
 		}
 		logger.Info("Creating RayClient Ingress")
 		rayClientName := rayClientNameFromCluster(&cluster)
-		rayClientIngressHost, _ := r.getIngressHost(ctx, r.kubeClient, &cluster, rayClientName)
+		rayClientIngressHost, err := r.getIngressHost(ctx, r.kubeClient, &cluster, rayClientName)
+		if err != nil {
+			logger.Error(err, "missing IngressDomain configuration in ConfigMap 'codeflare-operator-config'")
+			return ctrl.Result{RequeueAfter: requeueTime}, err
+		}
 		_, err = r.kubeClient.NetworkingV1().Ingresses(cluster.Namespace).Apply(ctx, desiredRayClientIngress(&cluster, rayClientIngressHost), metav1.ApplyOptions{FieldManager: controllerName, Force: true})
 		if err != nil {
 			logger.Error(err, "Failed to update RayClient Ingress")