addressing feedback

Author: Fiona-Waters

.github/workflows/e2e_tests.yaml

@@ -84,6 +84,7 @@ jobs:
           export CODEFLARE_TEST_TIMEOUT_SHORT=1m
           export CODEFLARE_TEST_TIMEOUT_MEDIUM=5m
           export CODEFLARE_TEST_TIMEOUT_LONG=10m
+          export CODEFLARE_TEST_TIMEOUT_GPU_PROVISIONING=30m
 
           export CODEFLARE_TEST_OUTPUT_DIR=${{ env.TEMP_DIR }}
           echo "CODEFLARE_TEST_OUTPUT_DIR=${CODEFLARE_TEST_OUTPUT_DIR}" >> $GITHUB_ENV

test/support/ocm.go

@@ -43,7 +43,7 @@ func buildOCMConnection(secret string) (*ocmsdk.Connection, error) {
 	connection, err := ocmsdk.NewConnectionBuilder().
 		Tokens(secret).
 		Build()
-	if err != nil || connection == nil {
+	if err != nil {
 		fmt.Fprintf(os.Stderr, "Can't build connection: %v\n", err)
 		return nil, err
 	}

test/support/support.go

@@ -58,6 +58,13 @@ func init() {
 			fmt.Printf("Error parsing CODEFLARE_TEST_TIMEOUT_LONG. Using default value: %s", TestTimeoutLong)
 		}
 	}
+	if value, ok := os.LookupEnv("CODEFLARE_TEST_TIMEOUT_GPU_PROVISIONING"); ok {
+		if duration, err := time.ParseDuration(value); err == nil {
+			TestTimeoutGpuProvisioning = duration
+		} else {
+			fmt.Printf("Error parsing CODEFLARE_TEST_TIMEOUT_GPU_PROVISIONING. Using default value: %s", TestTimeoutGpuProvisioning)
+		}
+	}
 
 	// Gomega settings
 	gomega.SetDefaultEventuallyTimeout(TestTimeoutShort)