Pr05 finals documentation and appendix #3710
Conversation
khanniie
left a comment
khanniie
left a comment
There was a problem hiding this comment.
thanks for the thorough documentation!
| <summary>The following files have been migrated, covering at least once instance of each 'kind' of file encountered on the repo:</summary> | ||
|
|
||
| - [x] `/common/types` | ||
| - [.] `/client/`: |
There was a problem hiding this comment.
not entirely sure why but i think these [.] still render as [.] plain text in the markdown!
There was a problem hiding this comment.
Ah I was trying indicate that it's partially complete, I'm ok with it being [.]!
|
|
||
| <details> | ||
| <summary> | ||
| Prefer `named` exports over `default` exports where possible |
There was a problem hiding this comment.
i think maybe things in html won't work with the ` so in the markdown they just show as that character for me
There was a problem hiding this comment.
Ah yeah I think the codeblock doesn't work within summary in md
I'm ok with this though to kind of indicate that it's a reference to code and not plain English
|
|
||
| ## Migration Tutorial: | ||
|
|
||
| [Video Guide - Migrating the `client/modules/User/pages/AccountView`](youtube.com/watch?v=y84SVy7lAgg&feature=youtu.be) |
There was a problem hiding this comment.
i think this link is relative rn so its broken for me
There was a problem hiding this comment.
Updated! I had an unlisted YouTube link that would work just for me bc I was logged in thanks for flagging! It's now public
There was a problem hiding this comment.
oh but i think it needs to be absolute like https:// ? otherwise it will make it relative to the markdown url
There was a problem hiding this comment.
I think it should be updated to https://youtube[...] already!
There was a problem hiding this comment.
ah sorry i must have been looking at an old version! thank you!
2 participants
Fixes #issue-number
Changes:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123