Skip to content

fix: set correct mimetype for project asset #3416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025
Merged

fix: set correct mimetype for project asset #3416

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eff0e3f
fix: set correct mimetype for project asset
dipamsen Mar 24, 2025
b2ec796
Merge branch 'develop' into add-contenttype
dipamsen Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions server/controllers/project.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import JSZip from 'jszip';
import format from 'date-fns/format';
import isUrl from 'is-url';
import { JSDOM } from 'jsdom';
import mime from 'mime';
import isAfter from 'date-fns/isAfter';
import axios from 'axios';
import slugify from 'slugify';
Expand Down Expand Up @@ -125,14 +126,18 @@ export async function getProjectAsset(req, res) {
if (!resolvedFile) {
return res.status(404).send({ message: 'Asset does not exist' });
}
const contentType =
mime.getType(resolvedFile.name) || 'application/octet-stream';
if (!resolvedFile.url) {
res.set('Content-Type', contentType);
return res.send(resolvedFile.content);
}

try {
const { data } = await axios.get(resolvedFile.url, {
responseType: 'arraybuffer'
});
res.set('Content-Type', contentType);
return res.send(data);
} catch (error) {
return res.status(404).send({ message: 'Asset does not exist' });
Expand Down