Skip to content

Conversation

@PiyushChandra17
Copy link
Contributor

Associated issue: #2042

Changes:

  • Used useHistory hook from react-router-dom instead of using global constant
  • More cleanup if condition in useEffect to check if username is true

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this seems good to me, thanks for your work on this!

@raclim raclim merged commit 99b9463 into processing:develop Jun 13, 2024
@raclim raclim mentioned this pull request Jun 13, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants