-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
file drawer filename space issue fixed #2117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
|
I further optimized it for any other space related issues and simplified using <span className="sidebar__file-item-name--ellipsis">
{middleText.charAt(0) === ' ' && <> </>}
{middleText.trim()}
{middleText.charAt(middleText.length - 1) === ' ' && <> </>}
</span> |
|
I think there's a simpler solution here via CSS. Changing |
|
@lindapaiste Thanks! I updated it |
raclim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
This is great, thanks so much @dewanshDT and @lindapaiste! |
|
Hooray, thank you! |
|
@raclim it’s great to see that you are reviewing PRs and this project is not dead! I have a bunch of stale PRs from July and August that are still sitting open. I stopped contributing after that because no one was looking at my contributions, but I would love to do more. Can you take a look at my open PRs? If I’m changing too much then maybe you can suggest what I should focus on. There’s quite a lot of old/outdated code which can easily be refactored so that’s mostly what I was doing. |
|
Thanks @lindapaiste for checking in and bringing this up, I'll try to take a look and have notes for your PRs by sometime early next week! I really appreciate your efforts and understanding, and would love for this project to receive more of your insight :) |
Fixes #2106
Changes:
I've made changes in the
client/modules/IDE/components/FileNode.jsxfile.I've added this in

FileName()function, as the html syntax was not detecting the space after the middle text which was causing the issue to occur, now it is fixedI have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123