Skip to content

Removes "find next", "find previous" options from Nav-edit dropdown options #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Removes "find next", "find previous" options from Nav-edit dropdown options #1768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac829da
removed options from edit drop down and also in translations
satyasaibhushan Feb 11, 2021
9479291
Merge branch 'develop' of https://github.com/processing/p5.js-web-edi…
satyasaibhushan Feb 17, 2021
cda6145
updated snapshot for jest tests
satyasaibhushan Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions client/components/Nav.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ class Nav extends React.PureComponent {
this.handleFind = this.handleFind.bind(this);
this.handleAddFile = this.handleAddFile.bind(this);
this.handleAddFolder = this.handleAddFolder.bind(this);
this.handleFindNext = this.handleFindNext.bind(this);
this.handleRun = this.handleRun.bind(this);
this.handleFindPrevious = this.handleFindPrevious.bind(this);
this.handleReplace = this.handleReplace.bind(this);
this.handleStop = this.handleStop.bind(this);
this.handleStartAccessible = this.handleStartAccessible.bind(this);
Expand Down Expand Up @@ -128,16 +126,6 @@ class Nav extends React.PureComponent {
this.setDropdown('none');
}

handleFindNext() {
this.props.cmController.findNext();
this.setDropdown('none');
}

handleFindPrevious() {
this.props.cmController.findPrev();
this.setDropdown('none');
}

handleReplace() {
this.props.cmController.showReplace();
this.setDropdown('none');
Expand Down Expand Up @@ -447,28 +435,6 @@ class Nav extends React.PureComponent {
<span className="nav__keyboard-shortcut">{metaKeyName}+F</span>
</button>
</li>
<li className="nav__dropdown-item">
<button
onClick={this.handleFindNext}
onFocus={this.handleFocusForEdit}
onBlur={this.handleBlur}
>
{this.props.t('Nav.Edit.FindNext')}
<span className="nav__keyboard-shortcut">{metaKeyName}+G</span>
</button>
</li>
<li className="nav__dropdown-item">
<button
onClick={this.handleFindPrevious}
onFocus={this.handleFocusForEdit}
onBlur={this.handleBlur}
>
{this.props.t('Nav.Edit.FindPrevious')}
<span className="nav__keyboard-shortcut">
{'\u21E7'}+{metaKeyName}+G
</span>
</button>
</li>
<li className="nav__dropdown-item">
<button
onClick={this.handleReplace}
Expand Down
22 changes: 0 additions & 22 deletions client/components/__test__/__snapshots__/Nav.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,28 +100,6 @@ exports[`Nav renders correctly 1`] = `
</span>
</button>
</li>
<li
class="nav__dropdown-item"
>
<button>
<span
class="nav__keyboard-shortcut"
>
⌃+G
</span>
</button>
</li>
<li
class="nav__dropdown-item"
>
<button>
<span
class="nav__keyboard-shortcut"
>
⇧+⌃+G
</span>
</button>
</li>
<li
class="nav__dropdown-item"
>
Expand Down
2 changes: 0 additions & 2 deletions translations/locales/en-US/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
"Title": "Edit",
"TidyCode": "Tidy Code",
"Find": "Find",
"FindNext": "Find Next",
"FindPrevious": "Find Previous",
"Replace": "Replace"
},
"Sketch": {
Expand Down
2 changes: 0 additions & 2 deletions translations/locales/es-419/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
"Title": "Editar",
"TidyCode": "Ordenar código",
"Find": "Buscar",
"FindNext": "Buscar siguiente",
"FindPrevious": "Buscar anterior",
"Replace": "Reemplazar"
},
"Sketch": {
Expand Down
2 changes: 0 additions & 2 deletions translations/locales/hi/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
"Title": "संपादित करे",
"TidyCode": "कोड साफ़ करें",
"Find": "खोज",
"FindNext": "अगला खोजें",
"FindPrevious": "पिछला खोजें",
"Replace": "बदली करें"
},
"Sketch": {
Expand Down
2 changes: 0 additions & 2 deletions translations/locales/ja/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
"Title": "編集",
"TidyCode": "コード整形",
"Find": "検索",
"FindNext": "次を検索",
"FindPrevious": "前を検索",
"Replace": "置換"
},
"Sketch": {
Expand Down