Skip to content

Fixes #1409 - adds username to url when fetching sketch from editor API #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2020
Merged

Fixes #1409 - adds username to url when fetching sketch from editor API #1436

merged 2 commits into from
May 28, 2020

Conversation

@catarak
Copy link
Member

@catarak catarak commented May 26, 2020

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@catarak catarak requested a review from joeyklee May 26, 2020 21:36
joeyklee
joeyklee approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@joeyklee joeyklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@catarak - I've tested the updated request URL and can confirm that this works!

Really nice solution here! I'm excited for the ability to share the human-friendly url names!

@catarak
Copy link
Member Author

catarak commented May 28, 2020 •
edited
Loading

thanks for testing :) i'm gonna merge this, and it will be fixed for the next release

@joeyklee
Copy link
Contributor

joeyklee commented May 28, 2020

Bravo!!! 🚀💯🥳

@catarak catarak merged commit 90195f4 into develop May 28, 2020
@catarak catarak deleted the slug-api-endpoint branch June 1, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joeyklee joeyklee joeyklee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@catarak @joeyklee