-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
add readme korean translation #1356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add readme korean translation #1356
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
|
Yay this is so awesome! Looking at this again, I think that it would make sense to put this at |
… into add-readme-ko-translation
|
changed the file structure accordingly! :-) |
|
Great! I'd also like to link to this file from the root README (like under the first header). I'd just do it myself but I don't know how to say Korean in Korean so... I'll let you do it 😄 |
|
Thanks for pointing it out! I'll make a table with links just like All Contributors Readme. Just after the header p5.js Web Editor and before its first paragraph begins. |
|
I have made a link to the translation/ko directory, so that a user could see the all the translated documents. Please let me know if you want something to be changed! :-) |
|
I was playing around with the table formatting a bit and decided to take it out. Otherwise looks good and going to merge this! |
|
Thank you for reviewing and organizing it! Yes, I agree that table didn't look great especially with just one box. A table could be useful when the number of supported languages grows to 10 or 20. Thanks for the merge! |
I have verified that this pull request:
npm run lint)Fixes #123Addresses #1350