Skip to content

Conversation

@Phe0
Copy link
Contributor

@Phe0 Phe0 commented Mar 14, 2020

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

Fixes #1320

@welcome
Copy link

welcome bot commented Mar 14, 2020

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@catarak
Copy link
Member

catarak commented Apr 6, 2020

I made a large feature merge ~1 wk ago and some of the docs have been updated. Would it be possible to get this in sync with master? Thank you!

@Phe0
Copy link
Contributor Author

Phe0 commented Apr 6, 2020

sure @catarak , I'll work on it

@Phe0
Copy link
Contributor Author

Phe0 commented Apr 6, 2020

@catarak I've updated the README translation and added translations for public_api_proposed.md and public_api.md

@catarak
Copy link
Member

catarak commented Apr 9, 2020

Amazing! So cool. Thank you!

There's something funky happening with your git history here. It says you're trying to merge in 250+ commits? Did you rebase to get to up to date with the tip of master?

@Phe0
Copy link
Contributor Author

Phe0 commented Apr 10, 2020

Amazing! So cool. Thank you!

There's something funky happening with your git history here. It says you're trying to merge in 250+ commits? Did you rebase to get to up to date with the tip of master?

Yes @catarak, I've rebased from the upstream master to get it up to date.

@catarak catarak closed this May 26, 2020
@catarak catarak reopened this May 26, 2020
@catarak catarak changed the base branch from master to develop August 26, 2020 19:08
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this in :)

@raclim raclim merged commit 99b1533 into processing:develop Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding brazilian portuguese developer docs

3 participants