Add BSON deserialize tests #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
approved these changes
Jun 10, 2025
Contributor
simolus3
left a comment
simolus3
left a comment
There was a problem hiding this comment.
Nice, thanks 👍 I didn't check all the input data either, but the test cases themselves make sense to me and since we match the behavior of another BSON library, this looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some BSON parsing tests, to make sure we parse all the types correctly. Even with the official BSON libraries I've seen some edge cases handled incorrectly (example), so I feel testing is important.
These tests cases were automatically generated by claude code, but I manually confirmed that the output matches that of the JS bson package.